New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST - add tests for various affine matrices for local tracking #1159

Merged
merged 3 commits into from Dec 18, 2016

Conversation

Projects
None yet
4 participants
@gabknight
Contributor

gabknight commented Dec 5, 2016

This PR supercedes PR #1045.

  • Allows higher tolerance for affine with a small 'shear' components
  • Tests various input affine matrices for local streamline tracking
@arokem

This comment has been minimized.

Member

arokem commented Dec 5, 2016

Excellent! Thanks for doing this. One small comment is that it would be helpful to have a little bit more comments: what is getting tested in each of the cases a1 - a6? Other than that, I am 👍 for a merge, as soon as Travis approves it.

@coveralls

This comment has been minimized.

coveralls commented Dec 5, 2016

Coverage Status

Coverage increased (+0.02%) to 88.025% when pulling 51785bf on gabknight:TST_affine_for_tracking into e1632e2 on nipy:master.

@codecov-io

This comment has been minimized.

codecov-io commented Dec 5, 2016

Current coverage is 85.49% (diff: 100%)

Merging #1159 into master will increase coverage by 0.02%

@@             master      #1159   diff @@
==========================================
  Files           214        214          
  Lines         24917      24960    +43   
  Methods           0          0          
  Messages          0          0          
  Branches       2526       2528     +2   
==========================================
+ Hits          21296      21339    +43   
  Misses         2989       2989          
  Partials        632        632          

Powered by Codecov. Last update 83ebf37...5f02a25

@arokem

This comment has been minimized.

Member

arokem commented Dec 5, 2016

The travis error (https://travis-ci.org/nipy/dipy/jobs/181390301) might get resolved once #1157 gets merged. We still need to make a call there.

@gabknight

This comment has been minimized.

Contributor

gabknight commented Dec 6, 2016

Thx @arokem. This was on my todo list for a while now :).

I added the small comments to the test as you suggested.

OK for the travis error, I will rebase this PR once #1157 is merged.

@coveralls

This comment has been minimized.

coveralls commented Dec 6, 2016

Coverage Status

Coverage increased (+0.02%) to 88.025% when pulling 9efe253 on gabknight:TST_affine_for_tracking into e1632e2 on nipy:master.

@arokem

This comment has been minimized.

Member

arokem commented Dec 16, 2016

If you rebase this one on master, I think that it should now pass

@gabknight gabknight force-pushed the gabknight:TST_affine_for_tracking branch from 9efe253 to 5f02a25 Dec 18, 2016

@coveralls

This comment has been minimized.

coveralls commented Dec 18, 2016

Coverage Status

Coverage increased (+0.02%) to 88.025% when pulling 5f02a25 on gabknight:TST_affine_for_tracking into 83ebf37 on nipy:master.

@gabknight

This comment has been minimized.

Contributor

gabknight commented Dec 18, 2016

All good! thx @arokem

@arokem

This comment has been minimized.

Member

arokem commented Dec 18, 2016

Great. Thank you!

@arokem arokem merged commit a0ddd21 into nipy:master Dec 18, 2016

4 checks passed

codecov/patch 100% of diff hit (target 85.46%)
Details
codecov/project 85.49% (+0.02%) compared to 83ebf37
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.02%) to 88.025%
Details

@gabknight gabknight deleted the gabknight:TST_affine_for_tracking branch Aug 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment