New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NF: added the repulsion 200 sphere. #1174

Merged
merged 1 commit into from Feb 10, 2017

Conversation

Projects
None yet
5 participants
@jchoude
Contributor

jchoude commented Jan 31, 2017

This sphere was generated using the electrostatic repulsion algorithm
to correctly space 200 points on the unit sphere.

This sphere is needed to reproduce results for the 2012 Raffelt paper
on Apparent Fiber Density (doi:10.1016/j.neuroimage.2011.10.045). They used a 200 points sphere.

NF: added the repulsion 200 sphere.
This sphere was generated using the electrostatic repulsion algorithm
to correctly space 200 points on the unit sphere.

This sphere is needed to reproduce results for the 2012 Raffelt paper
on Apparent Fiber Density.
@codecov-io

This comment has been minimized.

codecov-io commented Jan 31, 2017

Codecov Report

Merging #1174 into master will not impact coverage.

@@          Coverage Diff           @@
##           master   #1174   +/-   ##
======================================
  Coverage    85.8%   85.8%           
======================================
  Files         215     215           
  Lines       26001   26001           
  Branches     2668    2668           
======================================
  Hits        22310   22310           
  Misses       3038    3038           
  Partials      653     653
Impacted Files Coverage Δ
dipy/data/init.py 89.33% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94a4668...d505055. Read the comment docs.

@arokem

This comment has been minimized.

Member

arokem commented Jan 31, 2017

LGTM. Tell me that you are also planning to upload an example where you reproduce that paper! ;-)

@RafaelNH

This comment has been minimized.

Contributor

RafaelNH commented Jan 31, 2017

Any plans of incorporating the electrostatic repulsion algorithm code in dipy? I am guessing that you cannot use function disperse_charges from dipy.core.sphere because this assumes bipolar repulsion to space directions on the hemisphere, right?

@coveralls

This comment has been minimized.

coveralls commented Jan 31, 2017

Coverage Status

Coverage remained the same at 88.306% when pulling d505055 on jchoude:NF_add_repulsion200_sphere into 94a4668 on nipy:master.

@jchoude

This comment has been minimized.

Contributor

jchoude commented Feb 1, 2017

@arokem Well, for that, I would need to add the code to compute said AFD :) Currently working on it, I'll try to merge it here.

@RafaelNH well, in fact, I used the disperse_charges function to tune the points. Maybe I didn't use the correct name for the algorithm?

@arokem

This comment has been minimized.

Member

arokem commented Feb 2, 2017

@RafaelNH : does that answer your question? I think this is all in order, but want to make sure that this makes sense to you, before merging.

@arokem

This comment has been minimized.

Member

arokem commented Feb 10, 2017

Since I haven't heard back, I will assume that this is fine. Here goes. Can't wait for the follow-up PR, @jchoude ;-)

@arokem arokem merged commit 658f6ab into nipy:master Feb 10, 2017

4 checks passed

codecov/patch Coverage not affected when comparing 94a4668...d505055
Details
codecov/project 85.8% remains the same compared to 94a4668
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 88.306%
Details

ShreyasFadnavis pushed a commit to ShreyasFadnavis/dipy that referenced this pull request Sep 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment