New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: fix interpolation call with Numpy 1.12 #1177

Merged
merged 1 commit into from Feb 6, 2017

Conversation

Projects
None yet
4 participants
@jchoude
Contributor

jchoude commented Feb 6, 2017

This fixed the issue described in #1176

Numpy 1.12 now Raises when indexing an with a double instead of an int. We cast to int.

@arokem

This comment has been minimized.

Member

arokem commented Feb 6, 2017

LGTM. I can merge as soon as Travis comes back green.

@codecov-io

This comment has been minimized.

codecov-io commented Feb 6, 2017

Codecov Report

Merging #1177 into master will not impact coverage.

@@          Coverage Diff           @@
##           master   #1177   +/-   ##
======================================
  Coverage    85.8%   85.8%           
======================================
  Files         215     215           
  Lines       26001   26001           
  Branches     2668    2668           
======================================
  Hits        22310   22310           
  Misses       3038    3038           
  Partials      653     653

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94a4668...08b1a50. Read the comment docs.

@coveralls

This comment has been minimized.

coveralls commented Feb 6, 2017

Coverage Status

Coverage remained the same at 88.306% when pulling 08b1a50 on jchoude:BF_fix_interpolation_numpy_1_12 into 94a4668 on nipy:master.

@arokem arokem merged commit 189776b into nipy:master Feb 6, 2017

4 checks passed

codecov/patch Coverage not affected when comparing 94a4668...08b1a50
Details
codecov/project 85.8% remains the same compared to 94a4668
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 88.306%
Details

ShreyasFadnavis pushed a commit to ShreyasFadnavis/dipy that referenced this pull request Sep 20, 2018

Merge pull request nipy#1177 from jchoude/BF_fix_interpolation_numpy_…
…1_12

BF: fix interpolation call with Numpy 1.12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment