Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
A lightweight UI for medical visualizations #2: TextBox #1183
@@ Coverage Diff @@ ## master #1183 +/- ## ========================================== + Coverage 85.93% 86.01% +0.08% ========================================== Files 219 219 Lines 26383 26613 +230 Branches 2706 2737 +31 ========================================== + Hits 22671 22890 +219 - Misses 3052 3055 +3 - Partials 660 668 +8
I started with docstring and PEP8 stuff. I'll have a second pass to check the code's logic.
I see you had to redo the
test_ui.log.gz file. I think it is too much hassle to redo it teach time we add one UI element. I would propose to split the function
test_ui into multiple smaller test functions (testing one UI element at the time). That way each test function would have its own
The only thing that is bugging me right now is the unusual behavior of the textbox. It doesn't feel like, let's say, a <textarea> in a browser. Specifically, in a <textarea> when it's full and needs to move the focus, a whole line is scrolled up instead of only one character at the time. Since it is usable as-is, I don't think we have to fix it this PR but we should at least flag it as an improvement issue.
@Garyfallidis: I think we could merge it and move to the next UI component. If we realize we something is not working as expected we can always fix it in a subsequent PR.
@MarcCote you're right about the <textarea>. I made it more like a multi-line box in HTML. Sure, we can probably have an issue (enhancement) to add that feature to it. It can also be flagged as a easy/first-commit kind of thing.
@Garyfallidis with the next PR, we'll have some refactoring in the base UI element, since we found an easier way of adding events to elements.