Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error handling in SDT #1192

Closed
wants to merge 3 commits into from

Conversation

@tjroine
Copy link

commented Mar 9, 2017

Catches ValueErrors

tjroine
Update csdeconv.py
Catches ValueErrors
dipy/reconst/csdeconv.py Outdated Show resolved Hide resolved
tjroine added 2 commits Mar 9, 2017
tjroine
tjroine
@arokem

This comment has been minimized.

Copy link
Member

commented Mar 9, 2017

Cross-reference with: #539

@arokem arokem changed the title Update csdeconv.py Error handling in SDT Mar 9, 2017

@coveralls

This comment has been minimized.

Copy link

commented Mar 9, 2017

Coverage Status

Coverage decreased (-0.02%) to 88.402% when pulling 363ba97 on tjroine:master into 32ed56b on nipy:master.

@coveralls

This comment has been minimized.

Copy link

commented Mar 9, 2017

Coverage Status

Coverage decreased (-0.02%) to 88.402% when pulling 363ba97 on tjroine:master into 32ed56b on nipy:master.

@codecov-io

This comment has been minimized.

Copy link

commented Mar 9, 2017

Codecov Report

Merging #1192 into master will decrease coverage by -0.02%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master    #1192      +/-   ##
==========================================
- Coverage   85.93%   85.91%   -0.02%     
==========================================
  Files         219      219              
  Lines       26383    26390       +7     
  Branches     2706     2707       +1     
==========================================
+ Hits        22671    22672       +1     
- Misses       3052     3056       +4     
- Partials      660      662       +2
Impacted Files Coverage Δ
dipy/reconst/csdeconv.py 86.85% <33.33%> (-1.67%)
dipy/utils/six.py 45.71% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32ed56b...363ba97. Read the comment docs.

@arokem

This comment has been minimized.

Copy link
Member

commented Mar 9, 2017

Would be great to have a test here, that demonstrates why this change is needed.

Maybe use the coefficients that you shared over on #539, to show that the exception is caught?

@arokem

This comment has been minimized.

Copy link
Member

commented Mar 23, 2017

Could you please rebase this on master? Also, have you had a chance to add a test here?

@arokem

This comment has been minimized.

Copy link
Member

commented Apr 13, 2017

Hello @tjroine : have you had a chance to take another look and address my comments on this PR? Thanks!

@arokem

This comment has been minimized.

Copy link
Member

commented May 9, 2017

This would be great to include in the upcoming release, but I am afraid that we can't merge it without a test.

@skoudoro

This comment has been minimized.

Copy link
Member

commented Dec 7, 2018

Hi @tjroine, can you give me the voxel, bval and bvecs generating this error? I can add a test for this and rebase but without this information, it will be hard to add a test.

thank you!

@arokem

This comment has been minimized.

Copy link
Member

commented Mar 15, 2019

This seems stalled. Would have been great to include, but the author is AWOL.

@arokem arokem closed this Mar 15, 2019

@tjroine

This comment has been minimized.

Copy link
Author

commented Mar 18, 2019

@arokem

This comment has been minimized.

Copy link
Member

commented Mar 18, 2019

No worries. We can always come back to this if someone runs into this kind of thing again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.