New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRG: Use dipy's array comparisons for tests #1196

Merged
merged 3 commits into from Apr 1, 2017

Conversation

Projects
None yet
5 participants
@arokem
Member

arokem commented Mar 23, 2017

potentially closes #1191

@coveralls

This comment has been minimized.

coveralls commented Mar 23, 2017

Coverage Status

Coverage increased (+0.0009%) to 88.433% when pulling 277f209 on arokem:array-comps-1194 into dd4a17b on nipy:master.

@codecov-io

This comment has been minimized.

codecov-io commented Mar 23, 2017

Codecov Report

Merging #1196 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1196      +/-   ##
==========================================
+ Coverage   85.96%   85.96%   +<.01%     
==========================================
  Files         221      221              
  Lines       27066    27068       +2     
  Branches     2769     2769              
==========================================
+ Hits        23267    23269       +2     
  Misses       3122     3122              
  Partials      677      677
Impacted Files Coverage Δ
dipy/tracking/tests/test_streamline.py 98.14% <100%> (ø) ⬆️
dipy/segment/tests/test_quickbundles.py 97.95% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98c472a...6bef518. Read the comment docs.

@arokem

This comment has been minimized.

Member

arokem commented Mar 23, 2017

OK - looks like this killed one of the failures. But not the other -- I will continue to investigate.

@arokem arokem force-pushed the arokem:array-comps-1194 branch from 277f209 to 2dbf9fa Mar 28, 2017

@arokem arokem changed the title from Use dipy's array comparisons for tests to MRG: Use dipy's array comparisons for tests Mar 28, 2017

@arokem

This comment has been minimized.

Member

arokem commented Mar 28, 2017

I believe that this should now resolve all issues raised in #1191

@matthew-brett

This comment has been minimized.

Member

matthew-brett commented Mar 28, 2017

If it does kill the failures, maybe make the numpy pre-release entry not 'allow-failure' in .travis.yml.

@coveralls

This comment has been minimized.

coveralls commented Mar 28, 2017

Coverage Status

Coverage increased (+0.0009%) to 88.456% when pulling 1ab6d6b on arokem:array-comps-1194 into 98c472a on nipy:master.

@arokem

This comment has been minimized.

Member

arokem commented Mar 28, 2017

I like that. Edgy. Let's see that it passes first.

@coveralls

This comment has been minimized.

coveralls commented Mar 28, 2017

Coverage Status

Coverage increased (+0.0009%) to 88.456% when pulling 1ab6d6b on arokem:array-comps-1194 into 98c472a on nipy:master.

@arokem

This comment has been minimized.

Member

arokem commented Mar 28, 2017

Looks like we have lift-off here. Did I do the right thing on that last commit?

@matthew-brett

This comment has been minimized.

Member

matthew-brett commented Mar 28, 2017

Looks right to me.

@coveralls

This comment has been minimized.

coveralls commented Mar 28, 2017

Coverage Status

Coverage increased (+0.0009%) to 88.456% when pulling 6bef518 on arokem:array-comps-1194 into 98c472a on nipy:master.

@MarcCote

This comment has been minimized.

Contributor

MarcCote commented Mar 29, 2017

That looks good to me.

@MarcCote MarcCote merged commit 677334f into nipy:master Apr 1, 2017

4 checks passed

codecov/patch 100% of diff hit (target 85.96%)
Details
codecov/project 85.96% (+<.01%) compared to 98c472a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.0009%) to 88.456%
Details

ShreyasFadnavis pushed a commit to ShreyasFadnavis/dipy that referenced this pull request Sep 20, 2018

Merge pull request nipy#1196 from arokem/array-comps-1194
MRG: Use dipy's array comparisons for tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment