New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: avoid log zero #1198

Merged
merged 9 commits into from Mar 29, 2017

Conversation

Projects
None yet
4 participants
@arokem
Member

arokem commented Mar 23, 2017

This continues #1086

@arokem

This comment has been minimized.

Member

arokem commented Mar 23, 2017

Let's see how our minimal numpy does with this...

@coveralls

This comment has been minimized.

coveralls commented Mar 24, 2017

Coverage Status

Coverage decreased (-0.002%) to 88.518% when pulling e3e45be on arokem:ENH_avoid_log_zero into 02ce52f on nipy:master.

@codecov-io

This comment has been minimized.

codecov-io commented Mar 24, 2017

Codecov Report

Merging #1198 into master will decrease coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1198      +/-   ##
==========================================
- Coverage   86.01%   85.96%   -0.06%     
==========================================
  Files         219      221       +2     
  Lines       26644    27073     +429     
  Branches     2745     2770      +25     
==========================================
+ Hits        22918    23273     +355     
- Misses       3056     3121      +65     
- Partials      670      679       +9
Impacted Files Coverage Δ
dipy/reconst/shm.py 86.64% <100%> (-0.2%) ⬇️
dipy/reconst/tests/test_shm.py 98.92% <100%> (+0.01%) ⬆️
dipy/data/fetcher.py 40.97% <0%> (-3.92%) ⬇️
dipy/data/__init__.py 89.54% <0%> (ø) ⬆️
dipy/segment/threshold.py 97.56% <0%> (ø) ⬆️
dipy/utils/six.py 45.71% <0%> (ø) ⬆️
dipy/segment/tissue.py 73.17% <0%> (ø)
dipy/segment/tests/test_mrf.py 92.5% <0%> (ø)
dipy/sims/voxel.py 90.62% <0%> (+1.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02ce52f...d13b803. Read the comment docs.

@arokem

This comment has been minimized.

Member

arokem commented Mar 24, 2017

Looks like it did OK. @jchoude : what do you think about this solution?

@coveralls

This comment has been minimized.

coveralls commented Mar 24, 2017

Coverage Status

Coverage decreased (-0.002%) to 88.518% when pulling 8ab5785 on arokem:ENH_avoid_log_zero into 02ce52f on nipy:master.

@jchoude

This comment has been minimized.

Contributor

jchoude commented Mar 28, 2017

Seems all good to me! I can merge if you want. Do we mind if the coveralls check did not pass (-0.002% difference)

@arokem

This comment has been minimized.

Member

arokem commented Mar 28, 2017

I think that coveralls is complaining because we added four lines of code, but didn't add tests. So the difference is negative, if tiny. I wouldn't worry about it. That said, I now added a test with zeros as input, to make sure that the warning is properly suppressed, and that the result is correct.

@jchoude

This comment has been minimized.

Contributor

jchoude commented Mar 28, 2017

Ok! I'll wait until Travis reports back, and then I'll merge this and close my original PR.

@coveralls

This comment has been minimized.

coveralls commented Mar 28, 2017

Coverage Status

Coverage decreased (-0.07%) to 88.455% when pulling d13b803 on arokem:ENH_avoid_log_zero into 02ce52f on nipy:master.

@coveralls

This comment has been minimized.

coveralls commented Mar 28, 2017

Coverage Status

Coverage decreased (-0.07%) to 88.455% when pulling d13b803 on arokem:ENH_avoid_log_zero into 02ce52f on nipy:master.

@jchoude

This comment has been minimized.

Contributor

jchoude commented Mar 29, 2017

Seems all good!

@jchoude jchoude merged commit acee6d7 into nipy:master Mar 29, 2017

3 of 4 checks passed

coverage/coveralls Coverage decreased (-0.07%) to 88.455%
Details
codecov/patch 100% of diff hit (target 86.01%)
Details
codecov/project Absolute coverage decreased by -0.05% but relative coverage increased by +13.98% compared to 02ce52f
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jchoude

This comment has been minimized.

Contributor

jchoude commented Mar 29, 2017

Thanks @arokem !

ShreyasFadnavis pushed a commit to ShreyasFadnavis/dipy that referenced this pull request Sep 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment