New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix out of bounds point not being classified OUTSIDEIMAGE (binary cla… #1201

Merged
merged 2 commits into from Mar 28, 2017

Conversation

Projects
None yet
4 participants
@matthieudumont
Contributor

matthieudumont commented Mar 28, 2017

Binary Classifier: Fix bad classification for a point 1 voxel outside the mask shape in any direction.

@matthieudumont matthieudumont requested review from Garyfallidis and jchoude Mar 28, 2017

@arokem

This comment has been minimized.

Member

arokem commented Mar 28, 2017

Would you mind adding a test that demonstrates why this fix is needed?

@coveralls

This comment has been minimized.

coveralls commented Mar 28, 2017

Coverage Status

Coverage remained the same at 88.455% when pulling 01afa48 on matthieudumont:OOB_Classifier into 98c472a on nipy:master.

@codecov-io

This comment has been minimized.

codecov-io commented Mar 28, 2017

Codecov Report

Merging #1201 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1201   +/-   ##
=======================================
  Coverage   85.96%   85.96%           
=======================================
  Files         221      221           
  Lines       27066    27066           
  Branches     2769     2769           
=======================================
  Hits        23267    23267           
  Misses       3122     3122           
  Partials      677      677
Impacted Files Coverage Δ
...ipy/tracking/local/tests/test_tissue_classifier.py 93.61% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98c472a...eceb206. Read the comment docs.

@coveralls

This comment has been minimized.

coveralls commented Mar 28, 2017

Coverage Status

Coverage remained the same at 88.455% when pulling eceb206 on matthieudumont:OOB_Classifier into 98c472a on nipy:master.

@arokem

This comment has been minimized.

Member

arokem commented Mar 28, 2017

Yup. LGTM. Thanks!

@arokem arokem merged commit e5fd2a0 into nipy:master Mar 28, 2017

4 checks passed

codecov/patch Coverage not affected when comparing 98c472a...eceb206
Details
codecov/project 85.96% remains the same compared to 98c472a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 88.455%
Details

ShreyasFadnavis pushed a commit to ShreyasFadnavis/dipy that referenced this pull request Sep 20, 2018

Merge pull request nipy#1201 from matthieudumont/OOB_Classifier
Fix out of bounds point not being classified OUTSIDEIMAGE (binary cla…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment