New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use integer division to avoid errors in indexing #1202

Merged
merged 1 commit into from Mar 30, 2017

Conversation

Projects
None yet
4 participants
@arokem
Member

arokem commented Mar 29, 2017

Fixes #1200

@@ -92,7 +92,7 @@
import matplotlib.pyplot as plt
axial_middle = data.shape[2] / 2
axial_middle = data.shape[2] // 2

This comment has been minimized.

@arokem

arokem Mar 29, 2017

Member

This line is the crucial change.

The others are just eliminating un-needed whitespace

@jchoude

Seems all good to me. Waiting on Travis, then will merge, except if @ghoshbishakh wants to take a look.

@coveralls

This comment has been minimized.

coveralls commented Mar 29, 2017

Coverage Status

Coverage remained the same at 88.455% when pulling 1bc443c on arokem:quick-start-np-index into acee6d7 on nipy:master.

@codecov-io

This comment has been minimized.

codecov-io commented Mar 29, 2017

Codecov Report

Merging #1202 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1202   +/-   ##
=======================================
  Coverage   85.96%   85.96%           
=======================================
  Files         221      221           
  Lines       27073    27073           
  Branches     2770     2770           
=======================================
  Hits        23273    23273           
  Misses       3123     3123           
  Partials      677      677

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acee6d7...1bc443c. Read the comment docs.

@jchoude

This comment has been minimized.

Contributor

jchoude commented Mar 30, 2017

Well, no one chimed in, and it's a really minor change, so I'll go ahead and merge.

Thanks @arokem

@jchoude jchoude merged commit 6887fbf into nipy:master Mar 30, 2017

4 checks passed

codecov/patch Coverage not affected when comparing acee6d7...1bc443c
Details
codecov/project 85.96% remains the same compared to acee6d7
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 88.455%
Details

ShreyasFadnavis pushed a commit to ShreyasFadnavis/dipy that referenced this pull request Sep 20, 2018

Merge pull request nipy#1202 from arokem/quick-start-np-index
Use integer division to avoid errors in indexing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment