New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #1204, and add a filter to suppress warnings. #1206

Merged
merged 2 commits into from Apr 3, 2017

Conversation

Projects
None yet
5 participants
@arokem
Member

arokem commented Mar 30, 2017

See also #1107

@coveralls

This comment has been minimized.

coveralls commented Mar 30, 2017

Coverage Status

Coverage increased (+0.001%) to 88.382% when pulling cbf5cf4 on arokem:revert-1204 into 69c7093 on nipy:master.

@coveralls

This comment has been minimized.

coveralls commented Mar 30, 2017

Coverage Status

Coverage increased (+0.001%) to 88.382% when pulling cbf5cf4 on arokem:revert-1204 into 69c7093 on nipy:master.

@codecov-io

This comment has been minimized.

codecov-io commented Mar 30, 2017

Codecov Report

Merging #1206 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1206      +/-   ##
==========================================
+ Coverage   85.87%   85.87%   +<.01%     
==========================================
  Files         221      221              
  Lines       27116    27119       +3     
  Branches     2776     2776              
==========================================
+ Hits        23285    23288       +3     
+ Misses       3148     3146       -2     
- Partials      683      685       +2
Impacted Files Coverage Δ
dipy/align/reslice.py 97.29% <100%> (+0.23%) ⬆️
dipy/utils/six.py 45.71% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69c7093...cbf5cf4. Read the comment docs.

@MarcCote

This comment has been minimized.

Contributor

MarcCote commented Apr 1, 2017

I agree with what you said. Thank you @dimrozakis for the clarification.

@MarcCote MarcCote merged commit 1f06d00 into nipy:master Apr 3, 2017

4 checks passed

codecov/patch 100% of diff hit (target 85.87%)
Details
codecov/project 85.87% (+<.01%) compared to 69c7093
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.001%) to 88.382%
Details

ShreyasFadnavis pushed a commit to ShreyasFadnavis/dipy that referenced this pull request Sep 20, 2018

Merge pull request nipy#1206 from arokem/revert-1204
Revert nipy#1204, and add a filter to suppress warnings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment