New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use integer division in reconst_gqi.py #1217

Merged
merged 6 commits into from Apr 11, 2017

Conversation

Projects
None yet
4 participants
@ghoshbishakh
Member

ghoshbishakh commented Apr 7, 2017

No description provided.

@ghoshbishakh

This comment has been minimized.

Member

ghoshbishakh commented Apr 7, 2017

lets check all the examples before merging this one

@codecov-io

This comment has been minimized.

codecov-io commented Apr 7, 2017

Codecov Report

Merging #1217 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1217   +/-   ##
=======================================
  Coverage   85.91%   85.91%           
=======================================
  Files         221      221           
  Lines       27247    27247           
  Branches     2782     2782           
=======================================
  Hits        23408    23408           
  Misses       3154     3154           
  Partials      685      685

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6c8dee...586909a. Read the comment docs.

@coveralls

This comment has been minimized.

coveralls commented Apr 7, 2017

Coverage Status

Coverage remained the same at 88.383% when pulling 15c6f38 on ghoshbishakh:fix1215 into 857ca39 on nipy:master.

@coveralls

This comment has been minimized.

coveralls commented Apr 7, 2017

Coverage Status

Coverage remained the same at 88.383% when pulling 1112bdc on ghoshbishakh:fix1215 into 857ca39 on nipy:master.

@arokem

This comment has been minimized.

Member

arokem commented Apr 9, 2017

Just checking: have you had a chance to check the other examples? I propose that add the changes to the other examples on this same PR.

@ghoshbishakh ghoshbishakh force-pushed the ghoshbishakh:fix1215 branch from 1112bdc to f9a0b5d Apr 11, 2017

@ghoshbishakh

This comment has been minimized.

Member

ghoshbishakh commented Apr 11, 2017

@arokem no still a few are left.

@coveralls

This comment has been minimized.

coveralls commented Apr 11, 2017

Coverage Status

Coverage remained the same at 88.415% when pulling f9a0b5d on ghoshbishakh:fix1215 into f6c8dee on nipy:master.

@ghoshbishakh

This comment has been minimized.

Member

ghoshbishakh commented Apr 11, 2017

@arokem All examples are working now! Ready to merge.

@coveralls

This comment has been minimized.

coveralls commented Apr 11, 2017

Coverage Status

Coverage remained the same at 88.415% when pulling 586909a on ghoshbishakh:fix1215 into f6c8dee on nipy:master.

@arokem

This comment has been minimized.

Member

arokem commented Apr 11, 2017

Awesome. Thanks for doing this!

@arokem arokem merged commit bdee770 into nipy:master Apr 11, 2017

4 checks passed

codecov/patch Coverage not affected when comparing f6c8dee...586909a
Details
codecov/project 85.91% remains the same compared to f6c8dee
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 88.415%
Details

ShreyasFadnavis pushed a commit to ShreyasFadnavis/dipy that referenced this pull request Sep 20, 2018

Merge pull request nipy#1217 from ghoshbishakh/fix1215
Use integer division in reconst_gqi.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment