New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRG:Data off dropbox #1219

Merged
merged 5 commits into from Apr 16, 2017

Conversation

Projects
None yet
4 participants
@arokem
Member

arokem commented Apr 13, 2017

No description provided.

@arokem

This comment has been minimized.

Member

arokem commented Apr 13, 2017

Hey @Garyfallidis : I don't have the "icomoon.tar.gz" file! Could you please share that with me?

@arokem

This comment has been minimized.

Member

arokem commented Apr 13, 2017

Oh - scratch that. I seem to have saved a copy of these icons elsewhere!

@coveralls

This comment has been minimized.

coveralls commented Apr 13, 2017

Coverage Status

Coverage remained the same at 88.415% when pulling 138ffe7 on arokem:data-off-dropbox into bdee770 on nipy:master.

@codecov-io

This comment has been minimized.

codecov-io commented Apr 13, 2017

Codecov Report

Merging #1219 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1219   +/-   ##
=======================================
  Coverage   85.91%   85.91%           
=======================================
  Files         221      221           
  Lines       27247    27247           
  Branches     2782     2782           
=======================================
  Hits        23408    23408           
+ Misses       3154     3152    -2     
- Partials      685      687    +2
Impacted Files Coverage Δ
dipy/data/fetcher.py 40.97% <ø> (ø) ⬆️
dipy/utils/six.py 45.71% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdee770...30c2db0. Read the comment docs.

arokem added some commits Apr 13, 2017

@arokem arokem changed the title from WIP:Data off dropbox to MRG:Data off dropbox Apr 13, 2017

@arokem

This comment has been minimized.

Member

arokem commented Apr 13, 2017

This is ready to go from my point of view. I have verified that all these data-sets can be retrieved from their new locations using the refactored fetcher functions.

@coveralls

This comment has been minimized.

coveralls commented Apr 13, 2017

Coverage Status

Coverage remained the same at 88.415% when pulling 30c2db0 on arokem:data-off-dropbox into bdee770 on nipy:master.

@coveralls

This comment has been minimized.

coveralls commented Apr 13, 2017

Coverage Status

Coverage remained the same at 88.415% when pulling 30c2db0 on arokem:data-off-dropbox into bdee770 on nipy:master.

@coveralls

This comment has been minimized.

coveralls commented Apr 13, 2017

Coverage Status

Coverage remained the same at 88.415% when pulling 30c2db0 on arokem:data-off-dropbox into bdee770 on nipy:master.

@arokem arokem requested a review from Garyfallidis Apr 13, 2017

@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented Apr 16, 2017

Great thanks!

@Garyfallidis Garyfallidis merged commit e5da8e7 into nipy:master Apr 16, 2017

4 checks passed

codecov/patch Coverage not affected when comparing bdee770...30c2db0
Details
codecov/project 85.91% remains the same compared to bdee770
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 88.415%
Details

ShreyasFadnavis pushed a commit to ShreyasFadnavis/dipy that referenced this pull request Sep 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment