New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NF: Check multi b-value #1221

Merged
merged 2 commits into from Apr 14, 2017

Conversation

Projects
None yet
4 participants
@arokem
Member

arokem commented Apr 13, 2017

Some models require that you have more than one (non-zero) b-value in your gradient table.

This new feature implements a simple function that checks a gradient table, to see that it has enough different b-values.

arokem added some commits Apr 13, 2017

NF: Check that a gradient table has multiple b-values.
This is required for some models, and we can use this to implement
error handling on model initialization.
@codecov-io

This comment has been minimized.

codecov-io commented Apr 13, 2017

Codecov Report

Merging #1221 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1221      +/-   ##
==========================================
+ Coverage   85.91%   85.92%   +0.01%     
==========================================
  Files         221      221              
  Lines       27247    27270      +23     
  Branches     2782     2785       +3     
==========================================
+ Hits        23408    23431      +23     
  Misses       3154     3154              
  Partials      685      685
Impacted Files Coverage Δ
dipy/core/gradients.py 97.32% <100%> (+0.32%) ⬆️
dipy/core/tests/test_gradients.py 98.12% <100%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0297078...d9fbe30. Read the comment docs.

@coveralls

This comment has been minimized.

coveralls commented Apr 13, 2017

Coverage Status

Coverage increased (+0.01%) to 88.424% when pulling d9fbe30 on arokem:check-multi-b into 0297078 on nipy:master.

@RafaelNH

This comment has been minimized.

Contributor

RafaelNH commented Apr 14, 2017

This looks good! I will merge this - it is only one added function and it is already well tested! I will add this into dki and fwdti!

@RafaelNH RafaelNH merged commit d3cb337 into nipy:master Apr 14, 2017

4 checks passed

codecov/patch 100% of diff hit (target 85.91%)
Details
codecov/project 85.92% (+0.01%) compared to 0297078
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.01%) to 88.424%
Details

ShreyasFadnavis pushed a commit to ShreyasFadnavis/dipy that referenced this pull request Sep 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment