Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
RF: Use cython imports instead of relying on extern #1228
@@ Coverage Diff @@ ## master #1228 +/- ## ======================================= Coverage 85.88% 85.88% ======================================= Files 221 221 Lines 27285 27285 Branches 2785 2785 ======================================= Hits 23435 23435 Misses 3165 3165 Partials 685 685
Apr 22, 2017
I immediately can't think of any way the stdlib imports could cause a change at at the 7th decimal place, only for Cython 0.25.1 / numpy 1.7.1. Maybe there's some randomness in the test?
You're right. This is also relatively new, so might just be the precision wasn't set appropriately: #1231
To answer your question: yes, there is some randomness in that test: https://github.com/nipy/dipy/blob/master/dipy/reconst/tests/test_dki_micro.py#L88-L89