New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RF: allow for scipy pre-release deprecations #1229

Merged
merged 1 commit into from Apr 19, 2017

Conversation

Projects
None yet
4 participants
@matthew-brett
Member

matthew-brett commented Apr 19, 2017

factorial, factorial2 should come from scipy.special.

See https://s3.amazonaws.com/archive.travis-ci.org/jobs/223388982/log.txt for
current failure on --pre testing, where warnings overcome the travis-ci log
limit.

RF: allow for scipy pre-release deprecations
factorial, factorial2 should come from scipy.special.
@coveralls

This comment has been minimized.

coveralls commented Apr 19, 2017

Coverage Status

Coverage decreased (-0.006%) to 88.384% when pulling bcb7e5e on matthew-brett:scipy-pre-compat into 568d14c on nipy:master.

@codecov-io

This comment has been minimized.

codecov-io commented Apr 19, 2017

Codecov Report

Merging #1229 into master will decrease coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1229      +/-   ##
==========================================
- Coverage   85.88%   85.88%   -0.01%     
==========================================
  Files         221      221              
  Lines       27285    27288       +3     
  Branches     2785     2785              
==========================================
+ Hits        23435    23436       +1     
- Misses       3165     3167       +2     
  Partials      685      685
Impacted Files Coverage Δ
dipy/reconst/mapmri.py 90.25% <50%> (-0.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 568d14c...bcb7e5e. Read the comment docs.

@matthew-brett

This comment has been minimized.

Member

matthew-brett commented Apr 19, 2017

Coverage failure is because we only test on one scipy version - I think that's unavoidable.

@arokem arokem merged commit e136639 into nipy:master Apr 19, 2017

1 of 4 checks passed

codecov/patch 50% of diff hit (target 85.88%)
Details
codecov/project 85.88% (-0.01%) compared to 568d14c
Details
coverage/coveralls Coverage decreased (-0.006%) to 88.384%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@arokem arokem referenced this pull request Apr 19, 2017

Merged

DKI Microstructural model #1226

@MarcCote MarcCote referenced this pull request Apr 21, 2017

Merged

Refactoring #12

ShreyasFadnavis pushed a commit to ShreyasFadnavis/dipy that referenced this pull request Sep 20, 2018

Merge pull request nipy#1229 from matthew-brett/scipy-pre-compat
RF: allow for scipy pre-release deprecations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment