New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Added environment override for dipy_home variable #1233

Merged
merged 3 commits into from May 7, 2017

Conversation

Projects
None yet
5 participants
@tomwright01
Contributor

tomwright01 commented Apr 25, 2017

The fetcher module defines a path based from the users home directory. This can cause a problem when running in a cluster environment where the home directory can be machine specific.

This PR enables an environment variable DIPY_HOME to override the default setting.

@coveralls

This comment has been minimized.

coveralls commented Apr 25, 2017

Coverage Status

Coverage decreased (-0.003%) to 88.591% when pulling 8eaf635 on tomwright01:master into 379ea81 on nipy:master.

@codecov-io

This comment has been minimized.

codecov-io commented Apr 25, 2017

Codecov Report

Merging #1233 into master will decrease coverage by <.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1233      +/-   ##
=========================================
- Coverage    86.1%   86.1%   -0.01%     
=========================================
  Files         223     223              
  Lines       27893   27895       +2     
  Branches     2828    2829       +1     
=========================================
  Hits        24018   24018              
- Misses       3179    3180       +1     
- Partials      696     697       +1
Impacted Files Coverage Δ
dipy/data/fetcher.py 40.11% <33.33%> (-0.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 379ea81...efdb9d0. Read the comment docs.

@coveralls

This comment has been minimized.

coveralls commented Apr 26, 2017

Coverage Status

Coverage decreased (-0.003%) to 88.591% when pulling b4488d2 on tomwright01:master into 379ea81 on nipy:master.

@coveralls

This comment has been minimized.

coveralls commented Apr 26, 2017

Coverage Status

Coverage decreased (-0.003%) to 88.591% when pulling efdb9d0 on tomwright01:master into 379ea81 on nipy:master.

@arokem

This comment has been minimized.

Member

arokem commented May 3, 2017

This looks fine to me. I've heard people complain that we are not using and XDG-compliant directory for the data, but as long as we are going to do this, I am fine with adding this additional twist. Anyone else have any comments about this?

@MarcCote

This comment has been minimized.

Contributor

MarcCote commented May 7, 2017

Good idea. LGTM

@arokem arokem merged commit b7aa619 into nipy:master May 7, 2017

1 of 4 checks passed

codecov/patch 33.33% of diff hit (target 86.1%)
Details
codecov/project 86.1% (-0.01%) compared to 379ea81
Details
coverage/coveralls Coverage decreased (-0.003%) to 88.591%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

ShreyasFadnavis pushed a commit to ShreyasFadnavis/dipy that referenced this pull request Sep 20, 2018

Merge pull request nipy#1233 from tomwright01/master
Feature: Added environment override for dipy_home variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment