New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Replace widget with ui components in example. #1246

Closed
wants to merge 43 commits into
base: master
from

Conversation

Projects
None yet
8 participants
@dmreagan
Contributor

dmreagan commented May 18, 2017

@ranveeraggarwal, @MarcCote, and @Garyfallidis:

I'm trying to update the viz_advanced example to use the new UI, and I've run into two quick problems.

First, after I interact with the slider, I can no longer rotate/zoom the data. If I move the panel, then I can interact with the data again. So it seems the panel behaves correctly, but the slider is stealing focus or something.

Second, how do I tell the slider what to do when the value updates? I tried to add callbacks following the example in viz_ui, but the method used there for the button doesn't seem to work for my slider.

@coveralls

This comment has been minimized.

coveralls commented May 18, 2017

Coverage Status

Coverage remained the same at 85.607% when pulling cb4197c on dmreagan:example_advanced_ui into 3f3e2f1 on nipy:master.

1 similar comment
@coveralls

This comment has been minimized.

coveralls commented May 18, 2017

Coverage Status

Coverage remained the same at 85.607% when pulling cb4197c on dmreagan:example_advanced_ui into 3f3e2f1 on nipy:master.

@codecov-io

This comment has been minimized.

codecov-io commented May 19, 2017

Codecov Report

Merging #1246 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1246      +/-   ##
==========================================
+ Coverage   87.04%   87.05%   +<.01%     
==========================================
  Files         226      226              
  Lines       28262    28262              
  Branches     3026     3026              
==========================================
+ Hits        24602    24603       +1     
  Misses       2976     2976              
+ Partials      684      683       -1
Impacted Files Coverage Δ
dipy/viz/actor.py 78.18% <ø> (ø) ⬆️
dipy/reconst/gqi.py 54.54% <100%> (ø) ⬆️
dipy/reconst/tests/test_interpolate.py 100% <100%> (ø) ⬆️
dipy/tracking/tests/test_metrics.py 100% <100%> (ø) ⬆️
dipy/reconst/odf.py 92.59% <100%> (ø) ⬆️
dipy/reconst/mapmri.py 90.25% <100%> (ø) ⬆️
dipy/reconst/dti.py 96.5% <100%> (ø) ⬆️
dipy/reconst/multi_voxel.py 92.85% <100%> (ø) ⬆️
dipy/reconst/tests/test_vec_val_vect.py 93.93% <100%> (ø) ⬆️
dipy/reconst/tests/test_shore.py 95.23% <100%> (ø) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 599af3e...9618a2f. Read the comment docs.

@dmreagan

This comment has been minimized.

Contributor

dmreagan commented May 19, 2017

I got the new UI slider working, but not in the way that was demonstrated in the viz_ui example. In viz_ui, a callback is added to a button using on_left_mouse_button_drag. That did not work for a LineSlider2D. Instead, I had to use add_callback. Why?

@coveralls

This comment has been minimized.

coveralls commented May 19, 2017

Coverage Status

Coverage remained the same at 85.607% when pulling 0216404 on dmreagan:example_advanced_ui into 3f3e2f1 on nipy:master.

1 similar comment
@coveralls

This comment has been minimized.

coveralls commented May 19, 2017

Coverage Status

Coverage remained the same at 85.607% when pulling 0216404 on dmreagan:example_advanced_ui into 3f3e2f1 on nipy:master.

@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented May 22, 2017

@ranveeraggarwal have you seen @dmreagan's question? Any ideas?

@ranveeraggarwal

This comment has been minimized.

Member

ranveeraggarwal commented May 24, 2017

@dmreagan did you run the viz_ui example? Does it give the same issue? If so, it might be a problem with VTK 7. I'll install it and confirm.

@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented May 24, 2017

Yes, the problem was also with viz_ui.py We used 7.1.0 not 7.0.0

@ranveeraggarwal

This comment has been minimized.

Member

ranveeraggarwal commented May 25, 2017

I didn't face such an issue with 6.3.0. We might have to look into API changes in 7.1.0. 😕

@coveralls

This comment has been minimized.

coveralls commented Jun 1, 2017

Coverage Status

Coverage remained the same at 85.607% when pulling 0a81d08 on dmreagan:example_advanced_ui into 3f3e2f1 on nipy:master.

1 similar comment
@coveralls

This comment has been minimized.

coveralls commented Jun 1, 2017

Coverage Status

Coverage remained the same at 85.607% when pulling 0a81d08 on dmreagan:example_advanced_ui into 3f3e2f1 on nipy:master.

@coveralls

This comment has been minimized.

coveralls commented Jun 16, 2017

Coverage Status

Coverage remained the same at 85.656% when pulling 2689a1c on dmreagan:example_advanced_ui into 599af3e on nipy:master.

1 similar comment
@coveralls

This comment has been minimized.

coveralls commented Jun 16, 2017

Coverage Status

Coverage remained the same at 85.656% when pulling 2689a1c on dmreagan:example_advanced_ui into 599af3e on nipy:master.

skoudoro and others added some commits Jun 16, 2017

Merge pull request #1260 from skoudoro/issue-999
removing absolute path in reconst
Merge pull request #1261 from skoudoro/issue-1001
removing absolute path in tracking module
Merge pull request #1254 from skoudoro/script_automation
Automate script installation
Merge pull request #1263 from arokem/sl-length-as-npint
MRG: Cast Streamline attrs to numpy ints, to avoid buffer mismatch.

Fixes casting error seen at See: https://nipy.bic.berkeley.edu/builders/dipy-bdist64-27/builds/122/steps/shell_12/logs/stdio
@coveralls

This comment has been minimized.

coveralls commented Jun 19, 2017

Coverage Status

Coverage remained the same at 85.656% when pulling 6796b31 on dmreagan:example_advanced_ui into 599af3e on nipy:master.

1 similar comment
@coveralls

This comment has been minimized.

coveralls commented Jun 19, 2017

Coverage Status

Coverage remained the same at 85.656% when pulling 6796b31 on dmreagan:example_advanced_ui into 599af3e on nipy:master.

@coveralls

This comment has been minimized.

coveralls commented Jun 19, 2017

Coverage Status

Coverage remained the same at 85.656% when pulling 9618a2f on dmreagan:example_advanced_ui into 599af3e on nipy:master.

1 similar comment
@coveralls

This comment has been minimized.

coveralls commented Jun 19, 2017

Coverage Status

Coverage remained the same at 85.656% when pulling 9618a2f on dmreagan:example_advanced_ui into 599af3e on nipy:master.

@arokem

This comment has been minimized.

Member

arokem commented Jun 20, 2017

I think this needs a rebase. There are a lot of commits here that are from PRs that have recently been merged. If you need help doing this, let us know. We can walk you through the process.

@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented Jun 21, 2017

Too much merging here. Closing this one and will reopen a new one. Coming soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment