New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slice through ODF fields - Rebased #1251

Closed
wants to merge 25 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@Garyfallidis
Member

Garyfallidis commented May 25, 2017

Rebased and looking again into tests. This PR supersedes
#1143

@coveralls

This comment has been minimized.

coveralls commented May 25, 2017

Coverage Status

Coverage decreased (-4.0%) to 81.616% when pulling a0a6983 on Garyfallidis:odf_slicer_rebased into e67f57b on nipy:master.

@codecov-io

This comment has been minimized.

codecov-io commented May 26, 2017

Codecov Report

Merging #1251 into master will decrease coverage by 7.45%.
The diff coverage is 14.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1251      +/-   ##
==========================================
- Coverage   87.04%   79.58%   -7.46%     
==========================================
  Files         225      225              
  Lines       28109    28282     +173     
  Branches     3014     3039      +25     
==========================================
- Hits        24468    22509    -1959     
- Misses       2968     5197    +2229     
+ Partials      673      576      -97
Impacted Files Coverage Δ
dipy/viz/fvtk.py 6.17% <100%> (-56.16%) ⬇️
dipy/viz/actor.py 5.88% <4.59%> (-72.3%) ⬇️
dipy/viz/tests/test_fvtk_actors.py 9.42% <4.93%> (-38.75%) ⬇️
dipy/viz/colormap.py 20.71% <80%> (-67.12%) ⬇️
dipy/viz/tests/test_fvtk_window.py 12.09% <0%> (-81.46%) ⬇️
dipy/viz/widget.py 6.71% <0%> (-81.35%) ⬇️
dipy/viz/interactor.py 19.48% <0%> (-78.58%) ⬇️
dipy/viz/ui.py 20.06% <0%> (-72.23%) ⬇️
dipy/viz/tests/test_interactor.py 18.18% <0%> (-71.6%) ⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e67f57b...022b1a5. Read the comment docs.

@coveralls

This comment has been minimized.

coveralls commented May 26, 2017

Coverage Status

Coverage decreased (-4.002%) to 81.605% when pulling 022b1a5 on Garyfallidis:odf_slicer_rebased into e67f57b on nipy:master.

@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented Jun 20, 2017

Closing this and continuing in #1269

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment