New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing absolute path in reconst #1260

Merged
merged 1 commit into from Jun 16, 2017

Conversation

Projects
None yet
4 participants
@skoudoro
Member

skoudoro commented Jun 16, 2017

The goal of this PR is just to resolve #999

@arokem

This comment has been minimized.

Member

arokem commented Jun 16, 2017

Awesome. Thanks for doing this. I'll wait for travis to be done and then we can merge this.

@codecov-io

This comment has been minimized.

codecov-io commented Jun 16, 2017

Codecov Report

Merging #1260 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1260      +/-   ##
==========================================
+ Coverage   87.04%   87.05%   +<.01%     
==========================================
  Files         226      226              
  Lines       28262    28262              
  Branches     3026     3026              
==========================================
+ Hits        24602    24603       +1     
  Misses       2976     2976              
+ Partials      684      683       -1
Impacted Files Coverage Δ
dipy/reconst/odf.py 92.59% <100%> (ø) ⬆️
dipy/reconst/tests/test_vec_val_vect.py 93.93% <100%> (ø) ⬆️
dipy/reconst/dti.py 96.5% <100%> (ø) ⬆️
dipy/reconst/shore.py 89.64% <100%> (ø) ⬆️
dipy/reconst/tests/test_shore.py 95.23% <100%> (ø) ⬆️
dipy/reconst/gqi.py 54.54% <100%> (ø) ⬆️
dipy/reconst/multi_voxel.py 92.85% <100%> (ø) ⬆️
dipy/reconst/tests/test_interpolate.py 100% <100%> (ø) ⬆️
dipy/reconst/mapmri.py 90.25% <100%> (ø) ⬆️
dipy/core/graph.py 75% <0%> (+1.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 599af3e...86174a1. Read the comment docs.

@coveralls

This comment has been minimized.

coveralls commented Jun 16, 2017

Coverage Status

Coverage remained the same at 85.656% when pulling 86174a1 on skoudoro:issue-999 into 599af3e on nipy:master.

1 similar comment
@coveralls

This comment has been minimized.

coveralls commented Jun 16, 2017

Coverage Status

Coverage remained the same at 85.656% when pulling 86174a1 on skoudoro:issue-999 into 599af3e on nipy:master.

@arokem arokem merged commit 8bc5b26 into nipy:master Jun 16, 2017

4 checks passed

codecov/patch 100% of diff hit (target 87.04%)
Details
codecov/project 87.05% (+<.01%) compared to 599af3e
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 85.656%
Details

@skoudoro skoudoro deleted the skoudoro:issue-999 branch Jun 17, 2017

ShreyasFadnavis pushed a commit to ShreyasFadnavis/dipy that referenced this pull request Sep 20, 2018

Merge pull request nipy#1260 from skoudoro/issue-999
removing absolute path in reconst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment