Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
VIZ: A lightweight UI for medical visualizations #6: 2D File Selector #1262
@@ Coverage Diff @@ ## master #1262 +/- ## ========================================== - Coverage 87.02% 86.98% -0.05% ========================================== Files 228 228 Lines 28852 29068 +216 Branches 3101 3131 +30 ========================================== + Hits 25108 25284 +176 - Misses 3038 3072 +34 - Partials 706 712 +6
Okay, this is really weird.
I don't get why this is happening.
I've started looking at this PR. Really awesome
The filedialog (this is also true for the UI Panel) needs to be clicked once before we are able to move it around. This happens with VTK 5.8 and VTK 6.0.0. With VTK 7.0.0, the clicked events are buggy as you mentioned.
Would it be easy to support scrolling with the mouse wheel?
Is it easy to support long click on the "scroll bar" arrows?
I think in the example we should be able to see when a file is selected. Can we change the text color? Or put a rectangle of a different color underneath it? Maybe for the moment, we could just display it somewhere (console or use another Textbox). Edit: Ok, I see the coloring seems to only work with VTK > 6.2. I still think we should find a way of showing the selected file. Do you know if we can put a border around a text actor?
It will be nice to be able to manually specify the current directory of the filedialog. Speaking of the current directory, I don't think we should modify the actual "current directory" of the program (which happens when using
This is indeed weird and shouldn't happen. I will look into this.
Not sure. I guess we'll need to have an invisible(?) rectangle between the two arrows and implement a scroll listener on it?
Again, we'll need to look into this. We'll also need to have a variable to determine the speed of scrolling (or, increase the speed as the button is kept pressed).
I am currently storing it in a variable, so it should be easy to display it. Adding a border? Let me see if that can happen. Worst case, we can hide/unhide a rectangle actor under the text.
I'll also need to work a bit more on the tests, the default way won't work.
Other than the small comment, looks good to me.
I see a few problems here:
@dmreagan some of these are bugs I need to work on before merging, other enhancements.
Yep, this is a persistence bug. Just got to know, working on it.
In the future, as an enhancement maybe?
This is a serious bug that needs to be explored. On it.
This will be the next PR. Menus like save/open are very common, so we will add them in the default API.