New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a decorator for skipping test if openmp is not available #1267

Merged
merged 1 commit into from Jun 20, 2017

Conversation

Projects
None yet
5 participants
@skoudoro
Member

skoudoro commented Jun 20, 2017

The goal of this PR is to avoid test failure on mac when openmp is not avalaible. is it ok for you @matthew-brett @Garyfallidis ?

@arokem

This comment has been minimized.

Member

arokem commented Jun 20, 2017

Should address #1265

@skoudoro

This comment has been minimized.

Member

skoudoro commented Jun 20, 2017

Right, I forgot it, Thanks !

@coveralls

This comment has been minimized.

coveralls commented Jun 20, 2017

Coverage Status

Coverage decreased (-0.02%) to 85.638% when pulling c965c91 on skoudoro:issue-1265 into b7c093d on nipy:master.

1 similar comment
@coveralls

This comment has been minimized.

coveralls commented Jun 20, 2017

Coverage Status

Coverage decreased (-0.02%) to 85.638% when pulling c965c91 on skoudoro:issue-1265 into b7c093d on nipy:master.

@codecov-io

This comment has been minimized.

codecov-io commented Jun 20, 2017

Codecov Report

Merging #1267 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1267      +/-   ##
==========================================
- Coverage   87.05%   87.04%   -0.01%     
==========================================
  Files         226      226              
  Lines       28262    28262              
  Branches     3026     3026              
==========================================
- Hits        24603    24602       -1     
  Misses       2976     2976              
- Partials      683      684       +1
Impacted Files Coverage Δ
dipy/denoise/tests/test_nlmeans.py 97.67% <100%> (ø) ⬆️
dipy/core/graph.py 73.8% <0%> (-1.2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7c093d...c965c91. Read the comment docs.

@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented Jun 20, 2017

Cool, thanks @skoudoro

@Garyfallidis Garyfallidis merged commit 09459ff into nipy:master Jun 20, 2017

3 of 4 checks passed

coverage/coveralls Coverage decreased (-0.02%) to 85.638%
Details
codecov/patch 100% of diff hit (target 87.05%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +12.94% compared to b7c093d
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@skoudoro skoudoro deleted the skoudoro:issue-1265 branch Jun 20, 2017

@arokem

This comment has been minimized.

Member

arokem commented Jun 20, 2017

ShreyasFadnavis pushed a commit to ShreyasFadnavis/dipy that referenced this pull request Sep 20, 2018

Merge pull request nipy#1267 from skoudoro/issue-1265
Adding a decorator for skipping test if openmp is not available
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment