New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected a small error condition #1290

Merged
merged 2 commits into from Jul 3, 2017

Conversation

Projects
None yet
5 participants
@ssheybani
Contributor

ssheybani commented Jun 30, 2017

Separated two different error conditions for clarity.

@codecov-io

This comment has been minimized.

codecov-io commented Jul 1, 2017

Codecov Report

Merging #1290 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1290      +/-   ##
==========================================
+ Coverage   87.11%   87.11%   +<.01%     
==========================================
  Files         228      228              
  Lines       28764    28766       +2     
  Branches     3090     3091       +1     
==========================================
+ Hits        25057    25059       +2     
  Misses       3003     3003              
  Partials      704      704
Impacted Files Coverage Δ
dipy/core/gradients.py 97.36% <100%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4b1419...3c6242e. Read the comment docs.

@coveralls

This comment has been minimized.

coveralls commented Jul 1, 2017

Coverage Status

Coverage increased (+0.001%) to 85.418% when pulling b7de904 on ssheybani:master into e4b1419 on nipy:master.

raise ValueError("bvecs should be (N, 3)")
if not np.all(bvecs_close_to_1[dwi_mask]):
raise ValueError("The vectors in bvecs should be unit (The tolerance"
"can be modified as an input parameter")

This comment has been minimized.

@jchoude

jchoude Jul 1, 2017

Contributor

Missing a closing parenthesis in your quoted text. Additionnally, missing a space " " after "tolerance" or before "can".

@coveralls

This comment has been minimized.

coveralls commented Jul 3, 2017

Coverage Status

Coverage increased (+0.001%) to 85.418% when pulling 3c6242e on ssheybani:master into e4b1419 on nipy:master.

@Garyfallidis Garyfallidis merged commit fcadce0 into nipy:master Jul 3, 2017

4 checks passed

codecov/patch 100% of diff hit (target 87.11%)
Details
codecov/project 87.11% (+<.01%) compared to e4b1419
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.001%) to 85.418%
Details
@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented Jul 3, 2017

Thank you @ssheybani

ShreyasFadnavis pushed a commit to ShreyasFadnavis/dipy that referenced this pull request Sep 20, 2018

Merge pull request nipy#1290 from ssheybani/master
Corrected a small error condition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment