New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Fix typos in dti.py reconstruction file doc. #1304

Merged
merged 1 commit into from Jul 17, 2017

Conversation

Projects
None yet
4 participants
@jhlegarreta
Contributor

jhlegarreta commented Jul 17, 2017

Fix typos in method documentation for the dti.py reconstruction file.

Jon Haitz Legarreta
DOC: Fix typos in dti.py reconstruction file doc.
Fix typos in method documentation for the dti.py reconstruction file.
@RafaelNH

This comment has been minimized.

Contributor

RafaelNH commented Jul 17, 2017

All looks fine!

@coveralls

This comment has been minimized.

coveralls commented Jul 17, 2017

Coverage Status

Coverage remained the same at 85.435% when pulling 25489b2 on jhlegarreta:FixDTIReconstDocTypos into 736cbb5 on nipy:master.

1 similar comment
@coveralls

This comment has been minimized.

coveralls commented Jul 17, 2017

Coverage Status

Coverage remained the same at 85.435% when pulling 25489b2 on jhlegarreta:FixDTIReconstDocTypos into 736cbb5 on nipy:master.

@codecov-io

This comment has been minimized.

codecov-io commented Jul 17, 2017

Codecov Report

Merging #1304 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1304   +/-   ##
=======================================
  Coverage   87.13%   87.13%           
=======================================
  Files         228      228           
  Lines       28800    28800           
  Branches     3093     3093           
=======================================
  Hits        25094    25094           
  Misses       3003     3003           
  Partials      703      703
Impacted Files Coverage Δ
dipy/reconst/dti.py 96.5% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 736cbb5...25489b2. Read the comment docs.

@RafaelNH

This comment has been minimized.

Contributor

RafaelNH commented Jul 17, 2017

All checks passed, and no conflicts! @jhlegarreta do you have more corrections to add, or can I merge this?

@jhlegarreta

This comment has been minimized.

Contributor

jhlegarreta commented Jul 17, 2017

@RafaelNH thanks for the review! Not for this file, so you can merge this.

I'm revising the Doc and examples to try to get a better grasp of the dipy environment and task in #1240 (still trying to devise how to proceed) so I may find other typos in other files. Not the ideal for the people that have merge rights, but since I don't think I'll be able to cover the entirety of the doc/files or I don't know when I'll stop, I'm doing PRs as I read the docs. I've got a bunch of other changes that I'll try to gather and commit in a single topic.

@RafaelNH RafaelNH merged commit 08d8d90 into nipy:master Jul 17, 2017

4 checks passed

codecov/patch Coverage not affected when comparing 736cbb5...25489b2
Details
codecov/project 87.13% remains the same compared to 736cbb5
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 85.435%
Details

ShreyasFadnavis pushed a commit to ShreyasFadnavis/dipy that referenced this pull request Sep 20, 2018

Merge pull request nipy#1304 from jhlegarreta/FixDTIReconstDocTypos
DOC: Fix typos in dti.py reconstruction file doc.

@jhlegarreta jhlegarreta deleted the jhlegarreta:FixDTIReconstDocTypos branch Oct 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment