New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Address small_delta vs. big_delta flipped parameters. #1328

Merged
merged 1 commit into from Sep 22, 2017

Conversation

Projects
None yet
4 participants
@jhlegarreta
Contributor

jhlegarreta commented Sep 9, 2017

Fix the small_delta and big_delta parameters of the reconst_mapmri
example being flipped.

@jhlegarreta

This comment has been minimized.

Contributor

jhlegarreta commented Sep 9, 2017

Addresses #1325

@coveralls

This comment has been minimized.

coveralls commented Sep 9, 2017

Coverage Status

Coverage decreased (-0.002%) to 85.333% when pulling 466afc1 on jhlegarreta:FixBigVsSmallDeltaFlipInMAPMRIReconstructionExample into e498e68 on nipy:master.

1 similar comment
@coveralls

This comment has been minimized.

coveralls commented Sep 9, 2017

Coverage Status

Coverage decreased (-0.002%) to 85.333% when pulling 466afc1 on jhlegarreta:FixBigVsSmallDeltaFlipInMAPMRIReconstructionExample into e498e68 on nipy:master.

@codecov-io

This comment has been minimized.

codecov-io commented Sep 18, 2017

Codecov Report

Merging #1328 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1328   +/-   ##
=======================================
  Coverage   87.02%   87.02%           
=======================================
  Files         228      228           
  Lines       28841    28841           
  Branches     3100     3100           
=======================================
  Hits        25099    25099           
  Misses       3037     3037           
  Partials      705      705

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0013f57...7a8d8bf. Read the comment docs.

Jon Haitz Legarreta Gorroño
BUG: Address small_delta vs. big_delta flipped parameters.
Fix the `small_delta` and `big_delta` parameters of the `reconst_mapmri`
example being flipped.

@jhlegarreta jhlegarreta force-pushed the jhlegarreta:FixBigVsSmallDeltaFlipInMAPMRIReconstructionExample branch from 466afc1 to 7a8d8bf Sep 20, 2017

@skoudoro

This comment has been minimized.

Member

skoudoro commented Sep 20, 2017

Looks good to me. Can you check and merge it @Garyfallidis ?

@skoudoro skoudoro merged commit fc7b865 into nipy:master Sep 22, 2017

3 checks passed

codecov/patch Coverage not affected when comparing 0013f57...7a8d8bf
Details
codecov/project 87.02% remains the same compared to 0013f57
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@skoudoro

This comment has been minimized.

Member

skoudoro commented Sep 22, 2017

Thanks @jhlegarreta !

ShreyasFadnavis pushed a commit to ShreyasFadnavis/dipy that referenced this pull request Sep 20, 2018

Merge pull request nipy#1328 from jhlegarreta/FixBigVsSmallDeltaFlipI…
…nMAPMRIReconstructionExample

BUG: Address small_delta vs. big_delta flipped parameters.

@jhlegarreta jhlegarreta deleted the jhlegarreta:FixBigVsSmallDeltaFlipInMAPMRIReconstructionExample branch Oct 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment