New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch a more specific warning in test_csdeconv #1335

Merged
merged 1 commit into from Sep 18, 2017

Conversation

Projects
None yet
4 participants
@skoudoro
Member

skoudoro commented Sep 18, 2017

The goal of this PR is to fix #1323.

Like @arokem said, the test was catching too many warnings. In this case, the test was catching this :

FutureWarning: 'rcond' parameter will change to the default of machine precision times ``max(M, N)`` where M and N are the input matrix dimensions. To use the future default and silence this warning we advise to pass 'rcond=None', to keep using the old, explicitly pass 'rcond=-1'.

@coveralls

This comment has been minimized.

coveralls commented Sep 18, 2017

Coverage Status

Coverage decreased (-0.003%) to 85.332% when pulling 89b5af3 on skoudoro:fix-issue-1323 into e498e68 on nipy:master.

@codecov-io

This comment has been minimized.

codecov-io commented Sep 18, 2017

Codecov Report

Merging #1335 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1335      +/-   ##
==========================================
- Coverage   87.04%   87.02%   -0.02%     
==========================================
  Files         228      228              
  Lines       28843    28841       -2     
  Branches     3099     3100       +1     
==========================================
- Hits        25105    25098       -7     
- Misses       3035     3037       +2     
- Partials      703      706       +3
Impacted Files Coverage Δ
dipy/reconst/tests/test_csdeconv.py 99.41% <100%> (-0.01%) ⬇️
dipy/denoise/tests/test_nlmeans.py 93.02% <0%> (-4.66%) ⬇️
dipy/core/graph.py 73.8% <0%> (-1.2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e498e68...89b5af3. Read the comment docs.

@arokem

This comment has been minimized.

Member

arokem commented Sep 18, 2017

Looks great. The coveralls failure is bogus, I believe. Merging!

@arokem arokem merged commit 7311acc into nipy:master Sep 18, 2017

3 of 4 checks passed

coverage/coveralls Coverage decreased (-0.003%) to 85.332%
Details
codecov/patch 100% of diff hit (target 87.04%)
Details
codecov/project Absolute coverage decreased by -0.01% but relative coverage increased by +12.95% compared to e498e68
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@skoudoro skoudoro deleted the skoudoro:fix-issue-1323 branch Sep 18, 2017

ShreyasFadnavis pushed a commit to ShreyasFadnavis/dipy that referenced this pull request Sep 20, 2018

Merge pull request nipy#1335 from skoudoro/fix-issue-1323
Catch a more specific warning in test_csdeconv
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment