New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test modification for windows 10 / numpy 1.14 #1336

Merged
merged 1 commit into from Sep 19, 2017

Conversation

Projects
None yet
4 participants
@skoudoro
Member

skoudoro commented Sep 18, 2017

This PR is a correction for test_dti.py which is failing on windows 10 / numpy 1.14

The arrays seems to be different on the 14nth decimal place. This is really strange.

This problem does not appear on linux.

@coveralls

This comment has been minimized.

coveralls commented Sep 18, 2017

Coverage Status

Coverage remained the same at 85.332% when pulling ee0f2f2 on skoudoro:windows-10-test-dti into 7311acc on nipy:master.

1 similar comment
@coveralls

This comment has been minimized.

coveralls commented Sep 18, 2017

Coverage Status

Coverage remained the same at 85.332% when pulling ee0f2f2 on skoudoro:windows-10-test-dti into 7311acc on nipy:master.

@codecov-io

This comment has been minimized.

codecov-io commented Sep 18, 2017

Codecov Report

Merging #1336 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1336   +/-   ##
=======================================
  Coverage   87.02%   87.02%           
=======================================
  Files         228      228           
  Lines       28841    28841           
  Branches     3100     3100           
=======================================
  Hits        25098    25098           
  Misses       3037     3037           
  Partials      706      706
Impacted Files Coverage Δ
dipy/reconst/tests/test_dti.py 99.6% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7311acc...ee0f2f2. Read the comment docs.

@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented Sep 19, 2017

Cool, thanks.

@Garyfallidis Garyfallidis merged commit 0013f57 into nipy:master Sep 19, 2017

4 checks passed

codecov/patch 100% of diff hit (target 87.02%)
Details
codecov/project 87.02% (+0%) compared to 7311acc
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 85.332%
Details

@skoudoro skoudoro deleted the skoudoro:windows-10-test-dti branch Sep 19, 2017

ShreyasFadnavis pushed a commit to ShreyasFadnavis/dipy that referenced this pull request Sep 20, 2018

Merge pull request nipy#1336 from skoudoro/windows-10-test-dti
Test modification for windows 10 / numpy 1.14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment