New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use legacy float array for printing numpy array #1352

Merged
merged 1 commit into from Oct 9, 2017

Conversation

Projects
None yet
3 participants
@skoudoro
Member

skoudoro commented Oct 9, 2017

This PR is inspired by @effigies to resolve printing problem. Indeed, Numpy change printing strategies so we revert printing behavior to keep Doctests from breaking.

Thanks to @matthew-brett for his advise.

this should resolve #1346

@codecov-io

This comment has been minimized.

codecov-io commented Oct 9, 2017

Codecov Report

Merging #1352 into master will decrease coverage by <.01%.
The diff coverage is 81.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1352      +/-   ##
==========================================
- Coverage   87.02%   87.02%   -0.01%     
==========================================
  Files         228      228              
  Lines       28841    28852      +11     
  Branches     3100     3101       +1     
==========================================
+ Hits        25099    25108       +9     
- Misses       3037     3038       +1     
- Partials      705      706       +1
Impacted Files Coverage Δ
dipy/tracking/streamline.py 97.95% <100%> (+0.01%) ⬆️
dipy/__init__.py 71.42% <100%> (+2.19%) ⬆️
dipy/tracking/metrics.py 81.12% <100%> (+0.09%) ⬆️
dipy/core/geometry.py 90.29% <100%> (+0.03%) ⬆️
dipy/tracking/life.py 97.8% <100%> (+0.01%) ⬆️
dipy/tracking/utils.py 86.93% <100%> (+0.03%) ⬆️
dipy/testing/__init__.py 77.77% <60%> (-6.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76d021a...9e9d489. Read the comment docs.

@skoudoro

This comment has been minimized.

Member

skoudoro commented Oct 9, 2017

I think this one is ready to go @arokem . Should I really need to add a test for setup_test function?

@arokem

This comment has been minimized.

Member

arokem commented Oct 9, 2017

No need. LGTM

@arokem arokem merged commit 33c78bd into nipy:master Oct 9, 2017

1 of 3 checks passed

codecov/patch 81.81% of diff hit (target 87.02%)
Details
codecov/project 87.02% (-0.01%) compared to 76d021a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@arokem

This comment has been minimized.

Member

arokem commented Oct 9, 2017

We should revisit #1280 at some point...

@skoudoro skoudoro deleted the skoudoro:fix-doctest-numpy branch Oct 9, 2017

ShreyasFadnavis pushed a commit to ShreyasFadnavis/dipy that referenced this pull request Sep 20, 2018

Merge pull request nipy#1352 from skoudoro/fix-doctest-numpy
use legacy float array for printing numpy array
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment