New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX : improve epilogue accessibility for workflow #1353

Merged
merged 7 commits into from Oct 13, 2017

Conversation

Projects
None yet
4 participants
@skoudoro
Member

skoudoro commented Oct 9, 2017

The goal of this PR is to resolve #1344.

Now, epilog is setting up via the keyword References in workflow docstring.

@skoudoro skoudoro requested a review from Garyfallidis Oct 9, 2017

arokem and others added some commits Oct 9, 2017

Merge pull request #1352 from skoudoro/fix-doctest-numpy
use legacy float array for printing numpy array
@codecov-io

This comment has been minimized.

codecov-io commented Oct 10, 2017

Codecov Report

Merging #1353 into master will decrease coverage by 0.04%.
The diff coverage is 89.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1353      +/-   ##
==========================================
- Coverage   87.02%   86.98%   -0.05%     
==========================================
  Files         228      228              
  Lines       28841    29076     +235     
  Branches     3100     3134      +34     
==========================================
+ Hits        25099    25291     +192     
- Misses       3037     3072      +35     
- Partials      705      713       +8
Impacted Files Coverage Δ
dipy/workflows/tests/workflow_tests_utils.py 100% <ø> (ø) ⬆️
dipy/tracking/metrics.py 81.12% <100%> (+0.09%) ⬆️
dipy/__init__.py 71.42% <100%> (+2.19%) ⬆️
dipy/tracking/streamline.py 97.95% <100%> (+0.01%) ⬆️
dipy/workflows/tests/test_iap.py 95% <100%> (+0.45%) ⬆️
dipy/workflows/base.py 79.41% <100%> (+0.46%) ⬆️
dipy/tracking/utils.py 86.93% <100%> (+0.03%) ⬆️
dipy/tracking/life.py 97.8% <100%> (+0.01%) ⬆️
dipy/core/geometry.py 90.29% <100%> (+0.03%) ⬆️
dipy/testing/__init__.py 77.77% <60%> (-6.84%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76d021a...6a2145d. Read the comment docs.

@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented Oct 11, 2017

Hi @skoudoro, there is one minor comment.

@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented Oct 13, 2017

Cool, thanks for the bug fix.

@Garyfallidis Garyfallidis merged commit 3287cb0 into nipy:master Oct 13, 2017

3 checks passed

codecov/patch 89.47% of diff hit (target 87.02%)
Details
codecov/project Absolute coverage decreased by -0.04% but relative coverage increased by +2.44% compared to 76d021a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@skoudoro skoudoro deleted the skoudoro:fix-epilogue-in-workflow branch Oct 17, 2017

ShreyasFadnavis pushed a commit to ShreyasFadnavis/dipy that referenced this pull request Sep 20, 2018

Merge pull request nipy#1353 from skoudoro/fix-epilogue-in-workflow
FIX : improve epilogue accessibility for workflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment