New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add picking to slicer - rebase #1356

Merged
merged 11 commits into from Oct 14, 2017

Conversation

Projects
None yet
4 participants
@dmreagan
Contributor

dmreagan commented Oct 13, 2017

I messed up my history for PR #1334 by rebasing, so here's a new PR.

@dmreagan dmreagan referenced this pull request Oct 13, 2017

Closed

Add picking to slicer #1334

@codecov-io

This comment has been minimized.

codecov-io commented Oct 13, 2017

Codecov Report

Merging #1356 into master will decrease coverage by <.01%.
The diff coverage is 93.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1356      +/-   ##
==========================================
- Coverage   87.03%   87.03%   -0.01%     
==========================================
  Files         228      228              
  Lines       29034    29049      +15     
  Branches     3128     3128              
==========================================
+ Hits        25269    25282      +13     
- Misses       3058     3059       +1     
- Partials      707      708       +1
Impacted Files Coverage Δ
dipy/viz/ui.py 90.34% <100%> (+0.1%) ⬆️
dipy/viz/actor.py 79.61% <83.33%> (+0.06%) ⬆️
dipy/core/graph.py 73.8% <0%> (-1.2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0964732...92225d7. Read the comment docs.

@Garyfallidis Garyfallidis merged commit 594d345 into nipy:master Oct 14, 2017

3 checks passed

codecov/patch 93.75% of diff hit (target 87.03%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +6.71% compared to 0964732
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Garyfallidis

This comment has been minimized.

Member

Garyfallidis commented Oct 14, 2017

Great! Thanks! We can pick :)

ShreyasFadnavis pushed a commit to ShreyasFadnavis/dipy that referenced this pull request Sep 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment