New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: Import Streamlines object directly from nibabel. #1367

Merged
merged 1 commit into from Oct 24, 2017

Conversation

Projects
None yet
3 participants
@arokem
Member

arokem commented Oct 24, 2017

Fixes #1366

@codecov-io

This comment has been minimized.

codecov-io commented Oct 24, 2017

Codecov Report

Merging #1367 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1367      +/-   ##
==========================================
- Coverage   87.03%   87.03%   -0.01%     
==========================================
  Files         228      228              
  Lines       29058    29058              
  Branches     3128     3128              
==========================================
- Hits        25292    25291       -1     
  Misses       3059     3059              
- Partials      707      708       +1
Impacted Files Coverage Δ
dipy/io/dpy.py 100% <100%> (ø) ⬆️
dipy/core/graph.py 73.8% <0%> (-1.2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1c1198...02ddc54. Read the comment docs.

@skoudoro

This comment has been minimized.

Member

skoudoro commented Oct 24, 2017

Thanks @arokem ! it works fine for me too so I merge

@skoudoro skoudoro merged commit 31165e5 into nipy:master Oct 24, 2017

3 checks passed

codecov/patch 100% of diff hit (target 87.03%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +12.96% compared to c1c1198
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@arokem

This comment has been minimized.

Member

arokem commented Oct 24, 2017

The thing that confuses me is why no tests were failing on Travis before... anyone have any ideas?

@skoudoro

This comment has been minimized.

Member

skoudoro commented Oct 24, 2017

At the moment, no idea, this confuses me too

@arokem

This comment has been minimized.

Member

arokem commented Oct 24, 2017

@peterneher: what OS are you on? I am on a mac -- maybe that's the source of the difference?

ShreyasFadnavis pushed a commit to ShreyasFadnavis/dipy that referenced this pull request Sep 20, 2018

Merge pull request nipy#1367 from arokem/fix-1366
BF: Import Streamlines object directly from nibabel.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment