New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Update developers' affiliations. #1368

Merged
merged 4 commits into from Nov 8, 2017

Conversation

Projects
None yet
4 participants
@jhlegarreta
Contributor

jhlegarreta commented Oct 26, 2017

Update the DIPY developers' affilitations to reflect their current
institution.

Take advantage of the topic to fix accents for MA-Côté.

Jon Haitz Legarreta Gorroño
DOC: Update developers' affiliations.
Update the DIPY developers' affilitations to reflect their current
institution.

Take advantage of the topic to fix accents for MA-Côté.
@jhlegarreta

This comment has been minimized.

Contributor

jhlegarreta commented Oct 26, 2017

Updated the affiliations of the DIPY developers.

For those developers whose affiliation has changed from the one listed in previous version and having two (or more) affiliations I only kept one that is apparently the main one (e.g. Christopher Nguyen, Emmanuel Caruyer).

I ignore the current state/affiliation of a few (e.g. Vatsala Swaroop) either because I found no related info or because their most recent indexed reference is not that recent.

In other cases, I ignore where they point to (e.g. Endolith) so I cannot update the related information.

Finally, the only apparently related reference to Andrew Lawrence was that belonging to Cambridge. But I am not sure whether this is correct.

May be the core maintainers have a better knowledge of the current affiliation of these folks.

May be Serge should be added as well to the list.

Other than that, I am aware that this is hard to maintain. Some folks [1] [2] have developed scripts to gather the contributor's list automatically from the GitHub API, but that does not solve the affiliation issue (unless the API provides a way to get it if specified at all).

@codecov-io

This comment has been minimized.

codecov-io commented Oct 26, 2017

Codecov Report

Merging #1368 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1368   +/-   ##
=======================================
  Coverage   87.04%   87.04%           
=======================================
  Files         228      228           
  Lines       29077    29077           
  Branches     3129     3129           
=======================================
  Hits        25311    25311           
  Misses       3059     3059           
  Partials      707      707

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26413a2...9a64a9b. Read the comment docs.

@skoudoro

This comment has been minimized.

Member

skoudoro commented Oct 30, 2017

Sure, you can add me :-). Thanks ! Currently, we use git shortlog -ns for updating this list. I do not think a new tool is necessary.

I will ask @Garyfallidis if he knows more, otherwise, we can merge it.

Jon Haitz Legarreta Gorroño
DOC: Update developers' affiliations.
Add Serge Koudoro.

@jhlegarreta jhlegarreta force-pushed the jhlegarreta:UpdateDevelopersListAffiliations branch from 7879b49 to b8cdaea Nov 7, 2017

@jhlegarreta

This comment has been minimized.

Contributor

jhlegarreta commented Nov 7, 2017

While adding Serge, looks like I squashed your commit 7879b49, @gabknight Sorry. Could you please add again your work? Thanks.

@jhlegarreta

This comment has been minimized.

Contributor

jhlegarreta commented Nov 7, 2017

OK, I cherry-picked it and pushed, so @gabknight no need to do anything.

@skoudoro ready to be merged once checks are OK.

@gabknight

This comment has been minimized.

Contributor

gabknight commented Nov 7, 2017

@skoudoro skoudoro merged commit cf483b6 into nipy:master Nov 8, 2017

3 checks passed

codecov/patch Coverage not affected when comparing 26413a2...9a64a9b
Details
codecov/project 87.04% remains the same compared to 26413a2
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@skoudoro

This comment has been minimized.

Member

skoudoro commented Nov 8, 2017

Thanks @jhlegarreta and @gabknight !

ShreyasFadnavis pushed a commit to ShreyasFadnavis/dipy that referenced this pull request Sep 20, 2018

Merge pull request nipy#1368 from jhlegarreta/UpdateDevelopersListAff…
…iliations

DOC: Update developers' affiliations.

@jhlegarreta jhlegarreta deleted the jhlegarreta:UpdateDevelopersListAffiliations branch Oct 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment