New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST - add tracking tests for PeaksAndMetricsDirectionGetter #1370

merged 3 commits into from Oct 31, 2017


None yet
3 participants

gabknight commented Oct 27, 2017

  • Added a new test for eudx direction getter (PeaksAndMetricsDirectionGetter) following the discussion in PR #1342
  • this PR should be merged before PR #1342

This comment has been minimized.

codecov-io commented Oct 27, 2017

Codecov Report

Merging #1370 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1370      +/-   ##
+ Coverage   87.03%   87.04%   +<.01%     
  Files         228      228              
  Lines       29058    29077      +19     
  Branches     3128     3129       +1     
+ Hits        25292    25311      +19     
  Misses       3059     3059              
  Partials      707      707
Impacted Files Coverage Δ
dipy/tracking/local/tests/ 97.44% <100%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bfb1b2...e2b6eb7. Read the comment docs.


LGTM, just a few pep8 comments and it can be merged

@@ -346,6 +350,68 @@ def allclose(x, y):
npt.assert_(np.allclose(sl, expected[2]))
def test_PeakDirectionTracker():

This comment has been minimized.


skoudoro Oct 30, 2017


PEP8: function name should be lowercase. I will be good if you can change all the test function name of this file :-)

"""This tests that the Peaks And Metrics Direction Getter plays nice
LocalTracking and produces reasonable streamlines in a simple example.
sphere = HemiSphere.from_sphere(unit_octahedron)

This comment has been minimized.


skoudoro Oct 30, 2017


you do not use this variable. Should we keep it?


This comment has been minimized.


gabknight commented Oct 31, 2017

Thx @skoudoro for your comments.

@skoudoro skoudoro merged commit 26413a2 into nipy:master Oct 31, 2017

3 checks passed

codecov/patch 100% of diff hit (target 87.03%)
codecov/project 87.04% (+<.01%) compared to 5bfb1b2
continuous-integration/travis-ci/pr The Travis CI build passed

ShreyasFadnavis pushed a commit to ShreyasFadnavis/dipy that referenced this pull request Sep 20, 2018

Merge pull request nipy#1370 from gabknight/TST_eudx
TST - add tracking tests for PeaksAndMetricsDirectionGetter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment