New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: update printing format for numpy 1.14 #1377

Merged
merged 1 commit into from Nov 18, 2017

Conversation

Projects
None yet
3 participants
@skoudoro
Member

skoudoro commented Nov 16, 2017

This PR is for resolving #1376 due to the change here on Numpy

@codecov-io

This comment has been minimized.

codecov-io commented Nov 16, 2017

Codecov Report

Merging #1377 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1377      +/-   ##
==========================================
- Coverage   87.01%   87.01%   -0.01%     
==========================================
  Files         228      228              
  Lines       29086    29086              
  Branches     3131     3131              
==========================================
- Hits        25310    25309       -1     
  Misses       3068     3068              
- Partials      708      709       +1
Impacted Files Coverage Δ
dipy/testing/__init__.py 77.77% <0%> (ø) ⬆️
dipy/core/graph.py 73.8% <0%> (-1.2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 991b279...7b16b2a. Read the comment docs.

@skoudoro

This comment has been minimized.

Member

skoudoro commented Nov 17, 2017

It seems to be ok @arokem. you can merge it even if I do not understand why Codecov is not happy.

@arokem arokem merged commit 6f205f3 into nipy:master Nov 18, 2017

1 of 3 checks passed

codecov/patch 0% of diff hit (target 87.01%)
Details
codecov/project 87.01% (-0.01%) compared to 991b279
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@skoudoro skoudoro deleted the skoudoro:fix-print-legacy branch Nov 20, 2017

ShreyasFadnavis pushed a commit to ShreyasFadnavis/dipy that referenced this pull request Sep 20, 2018

Merge pull request nipy#1377 from skoudoro/fix-print-legacy
FIX: update printing format for numpy 1.14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment