New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: numpy legacy print again... #1378

Merged
merged 1 commit into from Nov 21, 2017

Conversation

Projects
None yet
5 participants
@skoudoro
Member

skoudoro commented Nov 21, 2017

set version of Numpy print options due to recent change

@codecov-io

This comment has been minimized.

codecov-io commented Nov 21, 2017

Codecov Report

Merging #1378 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1378      +/-   ##
==========================================
+ Coverage   87.01%   87.01%   +<.01%     
==========================================
  Files         228      228              
  Lines       29086    29086              
  Branches     3131     3131              
==========================================
+ Hits        25309    25310       +1     
  Misses       3068     3068              
+ Partials      709      708       -1
Impacted Files Coverage Δ
dipy/testing/__init__.py 77.77% <0%> (ø) ⬆️
dipy/core/graph.py 75% <0%> (+1.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f205f3...9adfe01. Read the comment docs.

@skoudoro

This comment has been minimized.

Member

skoudoro commented Nov 21, 2017

It seems to be good now @Garyfallidis :-)

@arokem arokem merged commit 3d4a990 into nipy:master Nov 21, 2017

2 of 3 checks passed

codecov/patch 0% of diff hit (target 87.01%)
Details
codecov/project 87.01% (+<.01%) compared to 6f205f3
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@arokem arokem referenced this pull request Nov 21, 2017

Merged

Fix piesno type #1375

@skoudoro skoudoro deleted the skoudoro:fix-numpy-legacy-again branch Nov 21, 2017

@fissell

This comment has been minimized.

fissell commented Jan 17, 2018

Hi,
np.set_printoptions(sign='legacy') breaks my dipy test.
On an Ubuntu machine I have numpy '1.14.0' and installed dipy
via easy_install --upgrade dipy to get dipy version '0.13.0'.
dipy.test() generates 2 errors because
File "/data//lib/python2.7/site-packages/dipy-0.13.0-py2.7-linux-x86_64.egg/dipy/testing/init.py",
line 38, in setup_test np.set_printoptions(sign='legacy')
indicates: site-packages/numpy-1.14.0-py2.7-linux-x86_64.egg/numpy/core/arrayprint.py", line 83, in _make_options_dict
raise ValueError("sign option must be one of ' ', '+', or '-'")

Is there a version of dipy greater than 0.13.0 where this is fixed ?

thanks
Kate

@skoudoro

This comment has been minimized.

Member

skoudoro commented Jan 18, 2018

Hi @fissell,

Is there a version of dipy greater than 0.13.0 where this is fixed?

Not yet.

Dipy 0.14.0 will be released during the first week of February. This release includes this PR.
So at the moment, you have the following options:

  • wait 20 days for the release.
  • use the dev-master branch.
  • downgrade Numpy to 1.13 or Dipy to 1.12
@matthew-brett

This comment has been minimized.

Member

matthew-brett commented Jan 18, 2018

Hi Kate,

We may well have left this in the instructions somewhere, but easy_install is severely outdated now - and will likely cause ugly problems later - for example when upgrading - see https://matthew-brett.github.io/pydagogue/installing_on_debian.html for some recommendations.

Cheers,

Matthew

@fissell

This comment has been minimized.

fissell commented Jan 18, 2018

Thanks Matthew and Serge !

ShreyasFadnavis pushed a commit to ShreyasFadnavis/dipy that referenced this pull request Sep 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment