New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible fix for the inline compilation problem #1386

Merged
merged 2 commits into from Dec 7, 2017

Conversation

Projects
None yet
3 participants
@nilgoyette
Contributor

nilgoyette commented Dec 4, 2017

I'm not sure this will actually fix the problem because I have several others problems on Windows here. This PR is more of a way to test on your server.

@skoudoro

This comment has been minimized.

Member

skoudoro commented Dec 4, 2017

I try it, and it resolved the compilation error, but you have to add this change on the pyx file too.

@nilgoyette

This comment has been minimized.

Contributor

nilgoyette commented Dec 4, 2017

I did as you requested, but why did you tell me to add this change on the pyx file too? Was there a warning or an error for one of the OS?

@codecov-io

This comment has been minimized.

codecov-io commented Dec 4, 2017

Codecov Report

Merging #1386 into master will decrease coverage by 0.62%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1386      +/-   ##
==========================================
- Coverage   86.98%   86.36%   -0.63%     
==========================================
  Files         227      227              
  Lines       28946    29326     +380     
  Branches     3117     3186      +69     
==========================================
+ Hits        25179    25327     +148     
- Misses       3062     3296     +234     
+ Partials      705      703       -2
Impacted Files Coverage Δ
dipy/viz/actor.py 60.1% <0%> (-19.52%) ⬇️
dipy/viz/tests/test_actors.py 55.92% <0%> (-9.01%) ⬇️
dipy/tracking/utils.py 88.57% <0%> (+0.95%) ⬆️
dipy/utils/optpkg.py 75.75% <0%> (+4.32%) ⬆️
dipy/data/fetcher.py 46.51% <0%> (+5.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3b517b...9dc0609. Read the comment docs.

@nilgoyette

This comment has been minimized.

Contributor

nilgoyette commented Dec 6, 2017

The red X only mean that the test coverage decreased, right?

Is there anything else I can do? If not, we (Imeka) look forward to work with PFT so it would be nice if this commit can get merged.

@skoudoro

This comment has been minimized.

Member

skoudoro commented Dec 7, 2017

Hi @nilgoyette,

Was there a warning or an error for one of the OS?

warning on my Windows machine, I would like to understand why because it is really strange. Anyway, merging.

@skoudoro skoudoro merged commit e34445c into nipy:master Dec 7, 2017

2 of 3 checks passed

codecov/project 86.36% (-0.63%) compared to f3b517b
Details
codecov/patch Coverage not affected when comparing f3b517b...9dc0609
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

ShreyasFadnavis pushed a commit to ShreyasFadnavis/dipy that referenced this pull request Sep 20, 2018

Merge pull request nipy#1386 from nilgoyette/fix_1342_inline
Possible fix for the inline compilation problem
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment