New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: fixes #1399, removing an un-needed singleton dimension. #1400

Merged
merged 1 commit into from Jan 10, 2018

Conversation

Projects
None yet
3 participants
@arokem
Member

arokem commented Jan 10, 2018

Also, more testing, just to be sure.

BF: fixes #1399, removing an un-needed singleton dimension.
Also, more testing, just to be sure.
@skoudoro

This comment has been minimized.

Member

skoudoro commented Jan 10, 2018

Awesome ! Thanks for this @arokem !

@codecov-io

This comment has been minimized.

codecov-io commented Jan 10, 2018

Codecov Report

Merging #1400 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1400      +/-   ##
==========================================
- Coverage   87.08%   87.07%   -0.01%     
==========================================
  Files         228      227       -1     
  Lines       29264    29063     -201     
  Branches     3160     3125      -35     
==========================================
- Hits        25485    25308     -177     
+ Misses       3058     3046      -12     
+ Partials      721      709      -12
Impacted Files Coverage Δ
dipy/reconst/tests/test_dti.py 99.61% <100%> (ø) ⬆️
dipy/reconst/dti.py 96.5% <100%> (ø) ⬆️
dipy/workflows/reconst.py 79.5% <0%> (-3.63%) ⬇️
dipy/reconst/mapmri.py 89.39% <0%> (-0.39%) ⬇️
dipy/workflows/tests/test_reconst_mapmri.py
dipy/workflows/tests/test_reconst_dti.py 95.08% <0%> (+1.53%) ⬆️
dipy/testing/__init__.py 83.33% <0%> (+5.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c15c3ee...421362c. Read the comment docs.

@skoudoro skoudoro merged commit e0db0d7 into nipy:master Jan 10, 2018

3 checks passed

codecov/patch 100% of diff hit (target 87.08%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +12.91% compared to c15c3ee
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@skoudoro

This comment has been minimized.

Member

skoudoro commented Jan 10, 2018

Everything good on Travis, merging!

This was referenced Jan 10, 2018

ShreyasFadnavis pushed a commit to ShreyasFadnavis/dipy that referenced this pull request Sep 20, 2018

Merge pull request nipy#1400 from arokem/nipygh-1399
BF: fixes nipy#1399, removing an un-needed singleton dimension.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment