New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: Added .eddy_rotated_bvecs extension support #1410

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@naveenkumarmarri
Contributor

naveenkumarmarri commented Feb 2, 2018

for issue #1117

@naveenkumarmarri naveenkumarmarri changed the title from Added .eddy_rotated_bvecs extension support to BF: Added .eddy_rotated_bvecs extension support Feb 2, 2018

@codecov-io

This comment has been minimized.

codecov-io commented Feb 2, 2018

Codecov Report

Merging #1410 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1410      +/-   ##
==========================================
+ Coverage   87.26%   87.27%   +<.01%     
==========================================
  Files         229      229              
  Lines       29588    29593       +5     
  Branches     3170     3173       +3     
==========================================
+ Hits        25821    25826       +5     
  Misses       3039     3039              
  Partials      728      728
Impacted Files Coverage Δ
dipy/workflows/multi_io.py 70.45% <100%> (+1.16%) ⬆️
dipy/io/gradients.py 76.47% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2de97d4...10842a5. Read the comment docs.

@skoudoro

This comment has been minimized.

Member

skoudoro commented Feb 2, 2018

Hi @naveenkumarmarri, Thanks for this contribution!

Can you split this two commit into 2 different PR. Indeed, this PR resolve 2 completely different issue so it will not be easy to track.

Thanks!

@naveenkumarmarri

This comment has been minimized.

Contributor

naveenkumarmarri commented Feb 2, 2018

@skoudoro sure, will do it right away

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment