New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated links #1416

Merged
merged 9 commits into from Feb 12, 2018

Conversation

Projects
None yet
3 participants
@ArjitJ
Contributor

ArjitJ commented Feb 6, 2018

The goal of this PR is to fix #987

ArjitJ added some commits Feb 6, 2018

@codecov-io

This comment has been minimized.

codecov-io commented Feb 6, 2018

Codecov Report

Merging #1416 into master will increase coverage by 0.69%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1416      +/-   ##
==========================================
+ Coverage    86.7%   87.39%   +0.69%     
==========================================
  Files         236      237       +1     
  Lines       29877    30069     +192     
  Branches     3206     3232      +26     
==========================================
+ Hits        25904    26278     +374     
+ Misses       3238     3043     -195     
- Partials      735      748      +13
Impacted Files Coverage Δ
dipy/tracking/local/localtracking.py 97.59% <0%> (-2.41%) ⬇️
dipy/workflows/tests/test_reconst_csa_csd.py 95.52% <0%> (-0.56%) ⬇️
dipy/workflows/multi_io.py 68.8% <0%> (-0.5%) ⬇️
dipy/tracking/local/__init__.py 100% <0%> (ø) ⬆️
dipy/reconst/csdeconv.py 89.32% <0%> (ø) ⬆️
dipy/reconst/benchmarks/bench_vec_val_sum.py
dipy/reconst/benchmarks/bench_peaks.py
dipy/reconst/benchmarks/bench_csd.py
dipy/tracking/local/tests/test_local_tracking.py
dipy/segment/benchmarks/bench_quickbundles.py
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ae848e...07489e7. Read the comment docs.

@skoudoro

Thanks for this PR @ArjitJ. Below, you can see my small comment

ps: do not hesitate to squash your 4 commits in 1 commit.

doc/faq.rst Outdated
``IPython
<http://www.ipython.org/>`_.`
`IPython`_
.. _IPython: http://www.ipython.org/

This comment has been minimized.

@skoudoro

skoudoro Feb 6, 2018

Member

The link should be move to links_names.inc

This comment has been minimized.

@ArjitJ

ArjitJ Feb 7, 2018

Contributor

@skoudoro i added the link to links_names.inc but i am not sure if i have the permissions to squash and merge. Please correct me if i am wrong because i am a newbie and i dont know much about github

ArjitJ added some commits Feb 7, 2018

@skoudoro

Hi @ArjitJ, I still have an error when I generate the doc. Can you do the last changes requested below?

Everything will be ok after that. Thanks !

@@ -80,6 +80,7 @@
.. _numpy: http://numpy.scipy.org
.. _scipy: http://www.scipy.org
.. _ipython: http://ipython.scipy.org
.. _IPython: http://www.ipython.org/

This comment has been minimized.

@skoudoro

skoudoro Feb 12, 2018

Member

This line generates a conflict with the line above. Can you just remove it ?

Thanks

Update links_names.inc
Removed conflicting ipython link
@skoudoro

This comment has been minimized.

Member

skoudoro commented Feb 12, 2018

Great ! Thanks @ArjitJ ! merging!

@skoudoro skoudoro merged commit 666d783 into nipy:master Feb 12, 2018

3 checks passed

codecov/patch Coverage not affected when comparing 7ae848e...07489e7
Details
codecov/project 87.39% (+0.69%) compared to 7ae848e
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ArjitJ

This comment has been minimized.

Contributor

ArjitJ commented Feb 12, 2018

@skoudoro Thanks a lot! Even though i worked on a Really Tiny issue i got to learn a lot about how open-source works! Looking forward to taking up more issues :)

ShreyasFadnavis pushed a commit to ShreyasFadnavis/dipy that referenced this pull request Sep 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment