New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress rcond warning #1419

Merged
merged 2 commits into from Feb 9, 2018

Conversation

Projects
None yet
3 participants
@arokem
Member

arokem commented Feb 8, 2018

Suppresses another warning.

@arokem

This comment has been minimized.

Member

arokem commented Feb 8, 2018

Ugh. This convolves into it #1294. Sorry - let me rebase here, so these two are distinct.

@arokem arokem force-pushed the arokem:suppress_rcond_warning branch from 099ef68 to 1e84975 Feb 8, 2018

@arokem

This comment has been minimized.

Member

arokem commented Feb 8, 2018

et voila

@codecov-io

This comment has been minimized.

codecov-io commented Feb 9, 2018

Codecov Report

Merging #1419 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1419   +/-   ##
=======================================
  Coverage   86.82%   86.82%           
=======================================
  Files         243      243           
  Lines       30215    30215           
  Branches     3250     3250           
=======================================
  Hits        26234    26234           
  Misses       3241     3241           
  Partials      740      740
Impacted Files Coverage Δ
dipy/reconst/csdeconv.py 89.32% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9456782...21145a3. Read the comment docs.

@skoudoro

This comment has been minimized.

Member

skoudoro commented Feb 9, 2018

I just checked and this warning disappeared.

Thanks @arokem ! merging !

@skoudoro skoudoro merged commit cb33390 into nipy:master Feb 9, 2018

3 checks passed

codecov/patch 100% of diff hit (target 86.82%)
Details
codecov/project 86.82% (+0%) compared to 9456782
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

ShreyasFadnavis pushed a commit to ShreyasFadnavis/dipy that referenced this pull request Sep 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment