Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[MRG] Improves delimiter in read_bvals_bvecs #1422
@@ Coverage Diff @@ ## master #1422 +/- ## ========================================== + Coverage 87.41% 87.43% +0.01% ========================================== Files 238 238 Lines 30282 30320 +38 Branches 3253 3253 ========================================== + Hits 26472 26510 +38 Misses 3057 3057 Partials 753 753
Thank you @thechargedneutron for fixing this issue. I made a couple of comments below and I hope it will help.
It would be nice if you can add unit tests. For this test, you need to create a fake file in a temporary folder, apply this function, and check if we have the expected result.
Thank you for adding this test. Do not hesitate to create
bval file with coma and tabs. it is good to test that too. You are on the right path! keep going!