New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mapmri workflow rebased #1428

Merged
merged 30 commits into from Mar 3, 2018

Conversation

Projects
None yet
4 participants
@arokem
Member

arokem commented Feb 12, 2018

I believe this is a rebased version of #1388

@skoudoro

This comment has been minimized.

Member

skoudoro commented Feb 13, 2018

Hi @arokem, Thanks for doing this! Can you rename dipy_mapmri to dipy_fit_mapmri. I believed the last version was #1395 and not #1388 but I need to check the difference.

@arokem arokem force-pushed the arokem:MAPMRI_Workflow_rebased branch from 9b85578 to 04f9785 Feb 14, 2018

@codecov-io

This comment has been minimized.

codecov-io commented Feb 17, 2018

Codecov Report

Merging #1428 into master will decrease coverage by 0.01%.
The diff coverage is 80.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1428      +/-   ##
==========================================
- Coverage   87.43%   87.42%   -0.02%     
==========================================
  Files         238      239       +1     
  Lines       30320    30449     +129     
  Branches     3253     3268      +15     
==========================================
+ Hits        26511    26620     +109     
- Misses       3057     3067      +10     
- Partials      752      762      +10
Impacted Files Coverage Δ
dipy/workflows/tests/test_reconst_dti.py 86.76% <27.27%> (-9.79%) ⬇️
dipy/workflows/reconst.py 81.31% <80.82%> (-0.85%) ⬇️
dipy/workflows/tests/test_reconst_mapmri.py 90.9% <90.9%> (ø)
dipy/reconst/mapmri.py 90.07% <0%> (+0.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b597aa...98ea6d0. Read the comment docs.

@arokem

This comment has been minimized.

Member

arokem commented Feb 17, 2018

Script renamed. Still need to figure out #1433...

@skoudoro

This comment has been minimized.

Member

skoudoro commented Mar 3, 2018

hi @arokem, can you rebase? it should be good after that

@arokem arokem force-pushed the arokem:MAPMRI_Workflow_rebased branch from 82560f3 to 98ea6d0 Mar 3, 2018

@arokem

This comment has been minimized.

Member

arokem commented Mar 3, 2018

@skoudoro skoudoro merged commit f9fa0bd into nipy:master Mar 3, 2018

1 of 3 checks passed

codecov/patch 80.57% of diff hit (target 87.43%)
Details
codecov/project 87.42% (-0.02%) compared to 4b597aa
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@skoudoro

This comment has been minimized.

Member

skoudoro commented Mar 3, 2018

Thank @arokem and @aarya22! merging mapmri workflow!

@skoudoro skoudoro referenced this pull request Mar 3, 2018

Closed

Mapmri workflow #1395

@arokem

This comment has been minimized.

Member

arokem commented Mar 3, 2018

Thanks! Congratulations @aarya22 on a nice contribution! 💯🥇🎆

cc @francopestilli

ShreyasFadnavis pushed a commit to ShreyasFadnavis/dipy that referenced this pull request Sep 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment