Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
NF - Bootstrap Direction Getter (cythonized) #1431
This was referenced
Feb 16, 2018
@skoudoro, Do you know what is this error:
I didn't run anything and I don't plan to. I simply checked the code and it's as good as cython can be. I can't actually complain because I started this cython crazyness :D
You can safely ignore this paragraph. It's not so much related to this PR, it's more of a general comment. I doubt cythonizing everything is a good idea. I don't know how much of DiPy is getting cythonized, but I know the % is increasing. We/you choosed Python because it's a super readable language with bateries included where you can code something quickly, then cython slowly creeps its way into the project. It's odd.
Thanks for the review @nilgoyette .
Okay will merge this because this work has been waiting for years and it seems working well. However, we need to correct many issues after this PR is merged. It needs more documentation, more docstrings and a better and clear tutorial. The current tutorial does not really explain the difference between using bootstrap and not. Also we need a plan for refactoring tracking. Let's call this a summer of tracking? @kesshijordan let's talk about this, in person this week. Thank you all for all these extreme amount of work! There is more to do. But good progress so far.