Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Raise Error when MDFmetric is used in QB or QBX #1440
I don't think you should remove the MDF metric as it is the only way right now to compute the distance between two streamlines unless you manually do the direct-flip comparison yourself (I'm talking without using Quickbundles).
To reduce ambiguity when using QB, we could raise an exception when
isinstance(metric, MDF) and tell the user to use
And to really fix the ambiguity we need to separate the metric used to compare streamlines (with centroids) and the metric used when merging a streamline to a new cluster (updating the centroid).
The main problem is that if someone reads the paper may go and use the MDF metric as input to QuickBundles although one should be using the AverageEuclidian metric. So, I think we should at least remove the MDF metric from the same tutorial with AverageEuclidian.
And I am not sure with using is isinstance(metric, MDF) but I can try it and see how it goes. Let me update this PR.... one sec...
Mar 4, 2018
@@ Coverage Diff @@ ## master #1440 +/- ## ========================================== + Coverage 87.41% 87.41% +<.01% ========================================== Files 239 239 Lines 30568 30579 +11 Branches 3289 3291 +2 ========================================== + Hits 26720 26731 +11 Misses 3078 3078 Partials 770 770