New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Link Coding Style Guide ref in CONTRIBUTING to the website. #1447

Merged
merged 1 commit into from Apr 14, 2018

Conversation

Projects
None yet
3 participants
@jhlegarreta
Contributor

jhlegarreta commented Mar 6, 2018

Link the Coding Style Guideline reference in CONTRIBUTING.md to the
website docs once it got merged, as suggested by @arokem in PR #1316.

Jon Haitz Legarreta Gorroño
DOC: Link Coding Style Guide ref in CONTRIBUTING to the website.
Link the Coding Style Guideline reference in `CONTRIBUTING.md` to the
website docs once it got merged, as suggested by @arokem in PR #1316.
@codecov-io

This comment has been minimized.

codecov-io commented Mar 7, 2018

Codecov Report

Merging #1447 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1447      +/-   ##
==========================================
- Coverage   87.42%   87.41%   -0.02%     
==========================================
  Files         239      239              
  Lines       30579    30579              
  Branches     3291     3291              
==========================================
- Hits        26735    26731       -4     
- Misses       3075     3078       +3     
- Partials      769      770       +1
Impacted Files Coverage Δ
dipy/data/fetcher.py 45.34% <0%> (-1.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 783dc06...98d0e0d. Read the comment docs.

@jhlegarreta

This comment has been minimized.

Contributor

jhlegarreta commented Mar 27, 2018

@skoudoro @arokem Codecov reports a (false?) decrease in the coverage, but this topic changes only the documentation. So I'd dare to say that this is ready to be merged.

@skoudoro

This comment has been minimized.

Member

skoudoro commented Apr 14, 2018

Thanks @jhlegarreta, LGTM, merging

@skoudoro skoudoro merged commit 167b1a5 into nipy:master Apr 14, 2018

2 of 3 checks passed

codecov/project 87.41% (-0.02%) compared to 783dc06
Details
codecov/patch Coverage not affected when comparing 783dc06...98d0e0d
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

ShreyasFadnavis pushed a commit to ShreyasFadnavis/dipy that referenced this pull request Sep 20, 2018

Merge pull request nipy#1447 from jhlegarreta/LinkCodingStyleGuideRef…
…ToWebsiteDocs

DOC: Link Coding Style Guide ref in CONTRIBUTING to the website.

@jhlegarreta jhlegarreta deleted the jhlegarreta:LinkCodingStyleGuideRefToWebsiteDocs branch Oct 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment