New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Manage multiple space delimiter #1450

Merged
merged 2 commits into from Mar 7, 2018

Conversation

Projects
None yet
3 participants
@skoudoro
Member

skoudoro commented Mar 7, 2018

fix #1449

We replace classic delimiter by space and save the result in a temporary file because we do not want to modify the original file.

@codecov-io

This comment has been minimized.

codecov-io commented Mar 7, 2018

Codecov Report

Merging #1450 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1450      +/-   ##
==========================================
+ Coverage   87.41%   87.41%   +<.01%     
==========================================
  Files         239      239              
  Lines       30579    30585       +6     
  Branches     3291     3291              
==========================================
+ Hits        26730    26736       +6     
- Misses       3078     3079       +1     
+ Partials      771      770       -1
Impacted Files Coverage Δ
dipy/io/gradients.py 90.47% <100%> (+10.98%) ⬆️
dipy/io/tests/test_io_gradients.py 96.05% <100%> (+0.16%) ⬆️
dipy/reconst/forecast.py 90.15% <0%> (-2.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2665eee...cf93d5d. Read the comment docs.

@Garyfallidis Garyfallidis merged commit 18f3d00 into nipy:master Mar 7, 2018

3 checks passed

codecov/patch 100% of diff hit (target 87.41%)
Details
codecov/project 87.41% (+<.01%) compared to 2665eee
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@skoudoro skoudoro deleted the skoudoro:fix-1449 branch Mar 12, 2018

ShreyasFadnavis pushed a commit to ShreyasFadnavis/dipy that referenced this pull request Sep 20, 2018

Merge pull request nipy#1450 from skoudoro/fix-1449
[Fix] Manage multiple space delimiter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment