New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Add the DIPY banner to the README file. #1451

Merged
merged 1 commit into from Mar 12, 2018

Conversation

Projects
None yet
3 participants
@jhlegarreta
Contributor

jhlegarreta commented Mar 7, 2018

Add the DIPY banner to the README.rst file to strenghten the
visual appeal of the repository and help the community better identify
the toolkit.

@codecov-io

This comment has been minimized.

codecov-io commented Mar 7, 2018

Codecov Report

Merging #1451 into master will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1451      +/-   ##
=========================================
+ Coverage   87.43%   87.5%   +0.07%     
=========================================
  Files         239     241       +2     
  Lines       30646   30789     +143     
  Branches     3307    3322      +15     
=========================================
+ Hits        26796   26943     +147     
+ Misses       3080    3071       -9     
- Partials      770     775       +5
Impacted Files Coverage Δ
dipy/tracking/streamline.py 95.83% <0%> (-2.13%) ⬇️
dipy/io/streamline.py 94.44% <0%> (ø)
dipy/io/tests/test_streamline.py 95.45% <0%> (ø)
dipy/tracking/tests/test_streamline.py 98.2% <0%> (+0.03%) ⬆️
dipy/io/trackvis.py 100% <0%> (+76.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 401b2d3...6f04fc0. Read the comment docs.

@skoudoro

Thanks @jhlegarreta. Below a small comment

README.rst Outdated
@@ -1,3 +1,7 @@
.. image:: doc/_static/dipy-banner.png
:alt: DIPY - Diffusion Imaging in Python
:target: doc/_static/dipy-banner.png

This comment has been minimized.

@skoudoro

skoudoro Mar 8, 2018

Member

I think it is better to target the website: http://dipy.org

This comment has been minimized.

@jhlegarreta

jhlegarreta Mar 8, 2018

Contributor

Thanks for the review. Seems reasonable. Done in commit 24b019e.

@jhlegarreta jhlegarreta force-pushed the jhlegarreta:AddDIPYBannerToREADME branch from dfd445a to 24b019e Mar 8, 2018

README.rst Outdated
@@ -1,3 +1,7 @@
.. image:: doc/_static/dipy-banner.png
:alt: DIPY - Diffusion Imaging in Python

This comment has been minimized.

@skoudoro

skoudoro Mar 12, 2018

Member

I do not why but it seems :target: should be before :alt: otherwise we do not see the image. Can you inverse this 2 properties?
Thanks @jhlegarreta

This comment has been minimized.

@jhlegarreta

jhlegarreta Mar 12, 2018

Contributor

Thanks for the review. Done !

@jhlegarreta jhlegarreta force-pushed the jhlegarreta:AddDIPYBannerToREADME branch from 24b019e to 6f04fc0 Mar 12, 2018

@jhlegarreta

This comment has been minimized.

Contributor

jhlegarreta commented Mar 12, 2018

Commit 6f04fc0 inverts the order of :target: and :alt:.

Jon Haitz Legarreta
DOC: Add the DIPY banner to the README file.
Add the **DIPY** banner to the `README.rst` file to strenghten the
visual appeal of the repository and help the community better identify
the toolkit.
@skoudoro

This comment has been minimized.

Member

skoudoro commented Mar 12, 2018

Great! Thanks @jhlegarreta, merging!

@skoudoro skoudoro merged commit f6af802 into nipy:master Mar 12, 2018

3 checks passed

codecov/patch Coverage not affected when comparing 401b2d3...6f04fc0
Details
codecov/project 87.5% (+0.07%) compared to 401b2d3
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jhlegarreta

This comment has been minimized.

Contributor

jhlegarreta commented Mar 13, 2018

@skoudoro thanks for merging this.

Not a big deal, but it looks like the target command is still not working as expected. In other projects I've seen it working for images linked to files hosted in the same repository. Just guessing, but may be it is not working due to security reasons?

@skoudoro

This comment has been minimized.

Member

skoudoro commented Mar 14, 2018

Strange... 😕, why does it work with all badges... we miss something...

ShreyasFadnavis pushed a commit to ShreyasFadnavis/dipy that referenced this pull request Sep 20, 2018

Merge pull request nipy#1451 from jhlegarreta/AddDIPYBannerToREADME
DOC: Add the DIPY banner to the README file.

@jhlegarreta jhlegarreta deleted the jhlegarreta:AddDIPYBannerToREADME branch Oct 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment