New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed window.record() to a large value #1453

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@ShreyasFadnavis
Contributor

ShreyasFadnavis commented Mar 10, 2018

No description provided.

@codecov-io

This comment has been minimized.

codecov-io commented Mar 10, 2018

Codecov Report

Merging #1453 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1453      +/-   ##
==========================================
- Coverage   87.42%   87.41%   -0.01%     
==========================================
  Files         239      239              
  Lines       30585    30585              
  Branches     3291     3291              
==========================================
- Hits        26740    26737       -3     
- Misses       3076     3079       +3     
  Partials      769      769
Impacted Files Coverage Δ
dipy/reconst/forecast.py 90.15% <0%> (-2.08%) ⬇️
dipy/core/graph.py 75% <0%> (+1.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18f3d00...d124f0a. Read the comment docs.

@ShreyasFadnavis

This comment has been minimized.

Contributor

ShreyasFadnavis commented Mar 10, 2018

Maybe I misunderstood?

@karandeepSJ

This comment has been minimized.

Contributor

karandeepSJ commented Mar 11, 2018

Did you try the 5000x5000 image on Linux? window.record() works fine on Linux. The problem is on Windows

@ShreyasFadnavis

This comment has been minimized.

Contributor

ShreyasFadnavis commented Mar 12, 2018

Yes, I did.. It works fine on my Windows PC!

@jchoude

This comment has been minimized.

Contributor

jchoude commented Mar 13, 2018

Is this for issue #1420? IF so, I don't think that's the fix that @dmreagan intended... This hardcoded value is not better, and might fail depending on the driver and GPU of the user. I guess that @dmreagan wanted something that could check that max resolution supported by the user's machine and work within those boundaries.

@dmreagan dmreagan added this to UI PR in Progress in Viz Module Mar 13, 2018

@dmreagan

This comment has been minimized.

Contributor

dmreagan commented Mar 13, 2018

@jchoude is correct that I wasn't looking for someone to change the values in the examples. I was hoping the underlying VTK functionality just wasn't being configured correctly for the case described in #1420. But it is good feedback from @ShreyasFadnavis and @karandeepSJ that large resolutions work correctly on your systems. I think it's probaby best to close this PR and continue the discussion in the issue.

@dmreagan dmreagan removed this from UI PR in Progress in Viz Module Apr 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment