New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using pyautogui to adapt to users' monitor size in viz examples #1455

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@ShreyasFadnavis
Contributor

ShreyasFadnavis commented Mar 13, 2018

No description provided.

@codecov-io

This comment has been minimized.

codecov-io commented Mar 13, 2018

Codecov Report

Merging #1455 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1455   +/-   ##
=======================================
  Coverage   87.49%   87.49%           
=======================================
  Files         241      241           
  Lines       30789    30789           
  Branches     3322     3322           
=======================================
  Hits        26939    26939           
  Misses       3074     3074           
  Partials      776      776

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6af802...8dc53eb. Read the comment docs.

@ShreyasFadnavis

This comment has been minimized.

Contributor

ShreyasFadnavis commented Mar 13, 2018

@dmreagan does this make sense/ is similar to what you wanted in #1420 ?

@dmreagan dmreagan added this to UI PR needs a review in Viz Module Mar 14, 2018

@dmreagan

This comment has been minimized.

Contributor

dmreagan commented Mar 14, 2018

Thanks for contributing, @ShreyasFadnavis, but this isn't what I'm looking for. It seems I should reword the issue description to make it more clear. I want to find out why I can't save large images on my system. Since you aren't seeing the issue on your system, it might be something specific to my setup.

@skoudoro

This comment has been minimized.

Member

skoudoro commented Mar 14, 2018

I have the same issue so I do not think, it is something speficic to you @dmreagan

I think you understood the problem @ShreyasFadnavis, but we do not want any other dependencies. You have to find a way to do the same with vtk and python standard library, then update record function where you can find here. So sorry, you can forget pyautogui

@dmreagan

This comment has been minimized.

Contributor

dmreagan commented Mar 14, 2018

You have to find a way to do the same with vtk and python standard library

I don't think that's correct. I don't want the examples to create renders at the detected monitor size. I want to find out why record isn't allowing you and me to render to sizes larger than our monitors.

@skoudoro

This comment has been minimized.

Member

skoudoro commented Mar 14, 2018

oh ok, Thanks for the update!

@dmreagan dmreagan removed this from UI PR needs a review in Viz Module Apr 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment