New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for "DiskSlider does not rotate actor in opposite direction" #1459

Closed
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@karandeepSJ
Contributor

karandeepSJ commented Mar 13, 2018

This PR fixes issue #1458

  • The problem was that the actor was being rotated every-time by the angle between the line joining center of base_disk and handle and the horizontal axis. It should have been rotated by angle equal to the change in angle between the line and horizontal axis.
  • To implement this, an attribute - pvalue was added to the DiskSlider2D class to store the previous value of rotation. This is used to calculate the angle by which the actor must be rotated.
@codecov-io

This comment has been minimized.

codecov-io commented Mar 14, 2018

Codecov Report

Merging #1459 into master will increase coverage by 0.01%.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1459      +/-   ##
=========================================
+ Coverage   87.49%   87.5%   +0.01%     
=========================================
  Files         241     241              
  Lines       30789   30799      +10     
  Branches     3322    3322              
=========================================
+ Hits        26939   26952      +13     
+ Misses       3074    3072       -2     
+ Partials      776     775       -1
Impacted Files Coverage Δ
dipy/viz/ui.py 89.3% <90%> (ø) ⬆️
dipy/reconst/forecast.py 92.22% <0%> (+2.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6af802...23996a6. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment