New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the Progit book link in the docs #1463

Closed
wants to merge 9 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@ShreyasFadnavis
Contributor

ShreyasFadnavis commented Mar 15, 2018

Patch to #1461

@codecov-io

This comment has been minimized.

codecov-io commented Mar 15, 2018

Codecov Report

Merging #1463 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1463      +/-   ##
=========================================
+ Coverage   87.49%   87.5%   +<.01%     
=========================================
  Files         241     241              
  Lines       30789   30789              
  Branches     3322    3322              
=========================================
+ Hits        26939   26942       +3     
+ Misses       3074    3071       -3     
  Partials      776     776
Impacted Files Coverage Δ
dipy/core/graph.py 73.8% <0%> (-1.2%) ⬇️
dipy/reconst/forecast.py 92.22% <0%> (+2.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6af802...708e2db. Read the comment docs.

@arokem

This comment has been minimized.

Member

arokem commented Mar 15, 2018

This seems to have convolved two PRs.

To see our recommended git workflow, please refer to the documentation: http://nipy.org/dipy/devel/gitwash/index.html

In particular, please use feature branches, instead of working on master, to avoid this kind of situation.

@ShreyasFadnavis

This comment has been minimized.

Contributor

ShreyasFadnavis commented Mar 15, 2018

@arokem Thank you! Will do that right away..

@arokem

This comment has been minimized.

Member

arokem commented Mar 15, 2018

Sorry - just now checked this. The old link works just fine. The new link doesn't.

Closing for now.

@arokem arokem closed this Mar 15, 2018

@arokem

This comment has been minimized.

Member

arokem commented Mar 15, 2018

Whoops. Looks like I am wrong. The new link is correct.

However, this PR is off of your master branch, and has too many commits at this point. Could you open a new PR off of a feature branch, with just one single commit fixing the link? I'll merge that if you create it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment